From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: BitBake developer list <bitbake-devel@lists.openembedded.org>
Subject: Re: docs on git fetcher don't match actual code
Date: Sun, 21 Aug 2011 10:40:45 -0700 [thread overview]
Message-ID: <1313948445.5939.2.camel@rex> (raw)
In-Reply-To: <alpine.DEB.2.02.1108191305430.5421@localhost6.localdomain6>
On Fri, 2011-08-19 at 13:11 -0400, Robert P. J. Day wrote:
> perusing the bitbake user manual earlier and the section on the git
> fetch module doesn't sync up with the code. from the user manual:
>
> "The parameters are tag, protocol and scmdata. tag is a Git tag, the
> default is ‘master’. protocol is the Git protocol to use and defaults
> to ‘rsync’."
>
> however, in fetch2/git.py, one reads:
>
> - protocol
> The method to use to access the repository. Common options are
> "git", "http", "file" and "rsync". The default is "git"
>
>
> and, finally, further down, there's the actual check for a valid
> protocol:
>
> if not ud.proto in ('git', 'file', 'ssh', 'http', 'https'):
> raise bb.fetch2.ParameterError("Invalid protocol type", ud.url)
>
> which says nothing about "rsync" but lists "https" as a valid protocol
> that's not mentioned higher up. someone way higher up the food chain
> is welcome to decide what should be clarified here.
Thanks, I've pushed a couple of commits which should clarify the
situation.
Cheers,
Richard
prev parent reply other threads:[~2011-08-21 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 17:11 docs on git fetcher don't match actual code Robert P. J. Day
2011-08-20 15:23 ` Holger Hans Peter Freyther
2011-08-20 15:27 ` Holger Freyther
2011-08-21 17:40 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313948445.5939.2.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox