From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] bitbake/lib/bb/msg.py: fix setting debug and verbosity levels
Date: Sun, 25 Sep 2011 16:26:19 +0100 [thread overview]
Message-ID: <1316964386.8185.19.camel@ted> (raw)
In-Reply-To: <8e4d22e7d6339849c7efb9460cafdfddb5ece76f.1316793495.git.paul.eggleton@linux.intel.com>
On Fri, 2011-09-23 at 17:05 +0100, Paul Eggleton wrote:
> The debug and verbosity levels (as set by the -D and -v command line
> options respectively) were not being passed through within msg.py since
> bitbake revision 45aad2f9647df14bcfa5e755b57e1ddab377939a due to
> incorrect variable names.
>
> Fixes [YOCTO #1513].
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> bitbake/lib/bb/build.py | 4 ++--
> bitbake/lib/bb/msg.py | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py
> index 00304b4..8937f08 100644
> --- a/bitbake/lib/bb/build.py
> +++ b/bitbake/lib/bb/build.py
> @@ -223,7 +223,7 @@ def exec_func_shell(function, d, runfile, cwd=None):
>
> with open(runfile, 'w') as script:
> script.write('#!/bin/sh -e\n')
> - if bb.msg.loggerVerbose:
> + if bb.msg.loggerDefaultVerbose:
> script.write("set -x\n")
> data.emit_func(function, script, d)
> if cwd:
> @@ -234,7 +234,7 @@ def exec_func_shell(function, d, runfile, cwd=None):
>
> cmd = runfile
>
> - if bb.msg.loggerVerbose:
> + if bb.msg.loggerDefaultVerbose:
> logfile = LogTee(logger, sys.stdout)
> else:
> logfile = sys.stdout
> diff --git a/bitbake/lib/bb/msg.py b/bitbake/lib/bb/msg.py
> index b7ae761..20d9bdd 100644
> --- a/bitbake/lib/bb/msg.py
> +++ b/bitbake/lib/bb/msg.py
> @@ -106,8 +106,8 @@ def init_msgconfig(verbose, debug, debug_domains = []):
> """
> Set default verbosity and debug levels config the logger
> """
> - bb.msg.loggerDebugLevel = debug
> - bb.msg.loggerVerbose = verbose
> + bb.msg.loggerDefaultDebugLevel = debug
> + bb.msg.loggerDefaultVerbose = verbose
> bb.msg.loggerDefaultDomains = debug_domains
>
> def addDefaultlogFilter(handler):
Merged to master, thanks.
Richard
next prev parent reply other threads:[~2011-09-25 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 16:04 [PATCH 0/1] bitbake: fix -D and -v options v2 Paul Eggleton
2011-09-23 16:05 ` [PATCH 1/1] bitbake/lib/bb/msg.py: fix setting debug and verbosity levels Paul Eggleton
2011-09-25 15:26 ` Richard Purdie [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-23 12:43 [PATCH 0/1] bitbake: fix -D and -v options Paul Eggleton
2011-09-23 12:43 ` [PATCH 1/1] bitbake/lib/bb/msg.py: fix setting debug and verbosity levels Paul Eggleton
2011-09-23 15:53 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316964386.8185.19.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox