From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: bitbake-devel@lists.openembedded.org, Zhenfeng.Zhao@windriver.com
Subject: Re: [PATCH 1/1] fetch2/__init__.py: add an "auto" policy for BB_SRCREV_POLICY
Date: Tue, 21 Aug 2012 14:59:22 +0100 [thread overview]
Message-ID: <1345557562.3907.87.camel@ted> (raw)
In-Reply-To: <50338D64.901@windriver.com>
On Tue, 2012-08-21 at 08:30 -0500, Jason Wessel wrote:
> I had asked Robert to follow up on this and intended this as a RFC,
> not a final implementation. This basically looks like the original
> patch I sent him when I was using the code to illustrate a possible
> solution to the problem of missing values from the data cache.
>
> Let us turn this into a discussion about the problem and see if we can
> come up with a plausible answer.
>
> We use the contrib/dump_cache.py to generate the entire list of
> possible recipes -> version -> package split mapping. As you can
> imagine this data is important and can be used for a number of
> purposes. I noticed a few values were missing when ever I ran the
> dump_cache.py and narrowed it down to the fact that anything that was
> listed as AUTOREV did not show up in the cache.
>
> The desired outcome is to have the key value pairs that were used in
> the most recent parse show up in the cache, as opposed to completely
> dropping the cache values from being written at all. For the version
> retrieval code, if the value in the cache is autorev, it should look
> up the value as one would expect. In terms of the clean vs cache vs a
> 3rd state, I don't really care what key words get used. You might
> not even need to add a 3rd state depending on the implementation of
> solution.
>
> I didn't see a reason not to write out the cache such that it could be
> parsed externally. Just because you write it, doesn't mean it has to
> get re-used in the case of the AUTOREV.
>
> If I have not described the problem clearly enough, please ask further
> questions. Is it a bit more clear what the nature of the problem is?
The problem is a lot clearer now, you basically want the data written to
the cache in the __BB_DONT_CACHE case. The trouble with the patch is we
tell bitbake to drop the data for good reason which is why the patch is
not acceptable.
I can imagine complaints about saving out data only to discard it at
load time and at this point I think your use of the cache is diverging
from what bitbake itself wants to use it for. I suspect what we might
need to do is extend cache.py to allow execution of custom cache
handlers and the you can write out the data you want. We already added
UI specific support to the cache so UIs could put extra data into the
cache although that perhaps doesn't cover this usecase :(.
Cheers,
Richard
next prev parent reply other threads:[~2012-08-21 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 8:56 [PATCH 0/1] fetch2/__init__.py: add an "auto" policy for BB_SRCREV_POLICY Robert Yang
2012-08-09 8:56 ` [PATCH 1/1] " Robert Yang
2012-08-21 13:08 ` Richard Purdie
2012-08-21 13:30 ` Jason Wessel
2012-08-21 13:59 ` Richard Purdie [this message]
2012-08-21 14:14 ` Jason Wessel
2012-08-21 14:58 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345557562.3907.87.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Zhenfeng.Zhao@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=jason.wessel@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox