From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Trevor Woerner <twoerner@gmail.com>
Cc: Chris Larson <clarson@kergoth.com>, bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] clarify wording
Date: Thu, 30 Aug 2012 17:38:27 -0700 [thread overview]
Message-ID: <1346373507.16485.17.camel@ted> (raw)
In-Reply-To: <CAHUNapQsabEeNV7ZrpZfro8R8OKakS-862UJy1w1_5LmSZU8eQ@mail.gmail.com>
On Sat, 2012-08-25 at 06:43 -0400, Trevor Woerner wrote:
> On Fri, Aug 24, 2012 at 11:57 PM, Chris Larson <clarson@kergoth.com> wrote:
> > No, this is wrong. When committing to the bitbake repository, there's
> > no need to prefix it with 'bitbake:'.
>
> I am new to bitbake-devel, but looking through several of the more
> recent commits would indicate the majority of them do have some sort
> of location identifier in the subject, some of which are just
> "bitbake:". One (e0f91faf195be63803d39fb42fcd115ad558c79f) even has
> "bin/bitbake:"; maybe I should use this for my patch?
I think in this case bin/bitbake: is the best prefix. The idea is it
gives a rough idea what changed and clearly in this case that is quite a
good summary.
Since this is such a simple patch, I've tweaked it and applied it. Also
in future please include a Signed-off-by: line.
Cheers,
Richard
next prev parent reply other threads:[~2012-08-31 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 0:22 [PATCH] clarify wording Trevor Woerner
2012-08-24 21:19 ` Andrei Gherzan
2012-08-24 21:35 ` Trevor Woerner
2012-08-24 21:43 ` Andrei Gherzan
2012-08-25 3:57 ` Chris Larson
2012-08-25 10:43 ` Trevor Woerner
2012-08-31 0:38 ` Richard Purdie [this message]
[not found] ` <CAK18fxEVCYsTypt-qa88Chjhu+qj4ry2FSdU8tUEnAZyCijcCQ@mail.gmail.com>
2012-08-25 21:00 ` Chris Larson
2012-08-25 22:46 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346373507.16485.17.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox