From: Mark Hatle <mark.hatle@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: [PATCH 1/2] utils.py: Check for duplication dependency entries
Date: Fri, 28 Sep 2012 12:27:49 -0500 [thread overview]
Message-ID: <1348853270-29676-1-git-send-email-mark.hatle@windriver.com> (raw)
explode_dep_versions is not able to have duplicate entries. Previously
duplicate entries ended up with the last item being the one returned to
the caller.
Instead we now throw a ValueType exception. This will ensure the caller
always gets the full set of declared dependencies.
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
lib/bb/utils.py | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib/bb/utils.py b/lib/bb/utils.py
index 82dab6b..fa5d2ab 100644
--- a/lib/bb/utils.py
+++ b/lib/bb/utils.py
@@ -159,6 +159,8 @@ def explode_dep_versions(s):
lastver = lastver + " " + (i[:-1] or "")
r[lastdep] = lastver
elif not inversion:
+ if i in r:
+ raise ValueError("Error, item %s appeared in dependency string '%s' multiple times. explode_dep_versions cannot cope with this." % (i, s))
r[i] = None
lastdep = i
lastver = ""
--
1.7.3.4
next reply other threads:[~2012-09-28 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 17:27 Mark Hatle [this message]
2012-09-28 17:27 ` [PATCH 2/2] utils.py: explode_dep_version - add ability to deal with whitespace Mark Hatle
2012-09-28 20:17 ` [PATCH 1/2] utils.py: Check for duplication dependency entries Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348853270-29676-1-git-send-email-mark.hatle@windriver.com \
--to=mark.hatle@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox