Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chris Larson <clarson@kergoth.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>,
	"Eggleton, Paul" <paul.eggleton@intel.com>
Subject: Re: [PATCH] build.py: Preserve sigdata files in the stamps directory
Date: Thu, 29 Nov 2012 12:21:17 +0000	[thread overview]
Message-ID: <1354191677.4053.1.camel@ted> (raw)
In-Reply-To: <CABcZANkDfxxQCupuJLEjJJfXM44MczWcSpvZCqQKmOsDbCPF5A@mail.gmail.com>

On Wed, 2012-11-28 at 15:19 -0700, Chris Larson wrote:
> On Wed, Nov 28, 2012 at 3:19 PM, Chris Larson <clarson@kergoth.com>
> wrote:
>         On Wed, Nov 28, 2012 at 1:26 PM, Richard Purdie
>         <richard.purdie@linuxfoundation.org> wrote:
>                 -        bb.utils.remove(mask)
>                 -
>                 +        # Preserve sigdata files in the stamps
>                 directory
>                 +        for name in glob.glob(mask):
>                 +            if name.find("sigdata") != -1:
>
>         if 'sigdata' not in name:
>
> Erm, s/not in/in/. You get the idea. Use of 'find' only really makes
> sense if you need the locations within the string.

Yes, good point, thanks.

Richard





      reply	other threads:[~2012-11-29 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 20:26 [PATCH] build.py: Preserve sigdata files in the stamps directory Richard Purdie
2012-11-28 22:19 ` Chris Larson
2012-11-28 22:19   ` Chris Larson
2012-11-29 12:21     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354191677.4053.1.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=clarson@kergoth.com \
    --cc=paul.eggleton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox