Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: bitbake-devel@lists.openembedded.org
Subject: [RFC] git: add BB_FETCH_PREMIRROR_READONLY option
Date: Tue, 30 Apr 2013 12:52:40 +0200	[thread overview]
Message-ID: <1367319160-19785-1-git-send-email-Martin.Jansa@gmail.com> (raw)

* just RFC, because I haven't even tested this change,
  use it only to describe the issue and discuss it

* remove symlink to ud.fullmirror when BB_FETCH_PREMIRROR_READONLY is set

* with read-only PREMIRROR (e.g. mounted over NFS or CIFS
  and referenced as file:///mnt/premirror) we cannot use
  BB_GENERATE_MIRROR_TARBALLS because all git2_abc.git.tar.gz
  files later became just symlinks to read-only location in PREMIRROR
  (it works fine on first build and for new components, because
  at that time there isn't tarball on PREMIRROR yet).

  ERROR: Fetcher failure: Fetch command failed with exit code 141, output:
  tar (child): /build/downloads/git2_abc.git.tar.gz: Cannot open: Read-only file system
  tar (child): Error is not recoverable: exiting now

* maybe we can change the default behavior and always remove symlink
  without introducing new option

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 lib/bb/fetch2/git.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py
index 052802e..14a8bc2 100644
--- a/lib/bb/fetch2/git.py
+++ b/lib/bb/fetch2/git.py
@@ -217,6 +217,10 @@ class Git(FetchMethod):
     def build_mirror_data(self, url, ud, d):
         # Generate a mirror tarball if needed
         if ud.write_tarballs and (ud.repochanged or not os.path.exists(ud.fullmirror)):
+            premirror_readonly = (d.getVar("BB_FETCH_PREMIRROR_READONLY", True) == "1")
+            if premirror_readonly and os.path.islink(ud.fullmirror):
+                os.unlink(origud.localpath)
+
             os.chdir(ud.clonedir)
             logger.info("Creating tarball of git repository")
             runfetchcmd("tar -czf %s %s" % (ud.fullmirror, os.path.join(".") ), d)
-- 
1.8.2.1




             reply	other threads:[~2013-04-30 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30 10:52 Martin Jansa [this message]
2013-04-30 12:57 ` [RFC] git: add BB_FETCH_PREMIRROR_READONLY option Paul Eggleton
2013-04-30 14:46   ` Martin Jansa
2013-05-03 15:58   ` [PATCHv2] git: remove symling before updating mirror tarball Martin Jansa
2013-05-07 16:39   ` [PATCHv3] " Martin Jansa
2013-05-07 21:51     ` Martin Jansa
2013-05-07 22:10       ` Martin Jansa
2013-05-10  9:35       ` Martin Jansa
2013-05-10 12:32         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367319160-19785-1-git-send-email-Martin.Jansa@gmail.com \
    --to=martin.jansa@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox