From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: utils: Improve better_compile error message
Date: Wed, 08 May 2013 18:16:00 +0100 [thread overview]
Message-ID: <1368033360.27116.93.camel@ted> (raw)
Similarly to the better_exec improvements, improve the compile failure
messages to be more user readable.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
index 9d7a32f..462eb68 100644
--- a/bitbake/lib/bb/utils.py
+++ b/bitbake/lib/bb/utils.py
@@ -255,18 +255,20 @@ def better_compile(text, file, realfile, mode = "exec"):
try:
return compile(text, file, mode)
except Exception as e:
+ error = []
# split the text into lines again
body = text.split('\n')
- logger.error("Error in compiling python function in %s", realfile)
- logger.error(str(e))
+ error.append("Error in compiling python function in %s:\n" % realfile)
if e.lineno:
- logger.error("The lines leading to this error were:")
- logger.error("\t%d:%s:'%s'", e.lineno, e.__class__.__name__, body[e.lineno-1])
- logger.error("\n".join(_print_trace(body, e.lineno)))
+ error.append("The code lines resulting in this error were:")
+ error.extend(_print_trace(body, e.lineno))
else:
- logger.error("The function causing this error was:")
+ error.append("The function causing this error was:")
for line in body:
- logger.error(line)
+ error.append(line)
+ error.append("%s: %s" % (e.__class__.__name__, str(e)))
+
+ logger.error("\n".join(error))
e = bb.BBHandledException(e)
raise e
reply other threads:[~2013-05-08 17:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368033360.27116.93.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox