From: Christopher Larson <kergoth@gmail.com>
To: bitbake-devel <bitbake-devel@lists.openembedded.org>
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: [PATCH 1/2] data_smart: use a split/filter/rejoin for _remove
Date: Tue, 27 Aug 2013 16:27:40 -0700 [thread overview]
Message-ID: <1377646061-24208-1-git-send-email-kergoth@gmail.com> (raw)
From: Christopher Larson <chris_larson@mentor.com>
This is more idiomatic, and from the limited performance testing I did, is
faster as well. See https://gist.github.com/kergoth/6360248 for the naive
benchmark.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
lib/bb/data_smart.py | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/lib/bb/data_smart.py b/lib/bb/data_smart.py
index 3fb88a9..6229fbf 100644
--- a/lib/bb/data_smart.py
+++ b/lib/bb/data_smart.py
@@ -589,13 +589,9 @@ class DataSmart(MutableMapping):
if expand and value:
value = self.expand(value, None)
if value and flag == "_content" and local_var and "_removeactive" in local_var:
- for i in local_var["_removeactive"]:
- if " " + i + " " in value:
- value = value.replace(" " + i + " ", " ")
- if value.startswith(i + " "):
- value = value[len(i + " "):]
- if value.endswith(" " + i):
- value = value[:-len(" " + i)]
+ filtered = filter(lambda v: v not in local_var["_removeactive"],
+ value.split(" "))
+ value = " ".join(filtered)
return value
def delVarFlag(self, var, flag, **loginfo):
--
1.8.3.4
next reply other threads:[~2013-08-27 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 23:27 Christopher Larson [this message]
2013-08-27 23:27 ` [PATCH 2/2] data_smart: allow removal of multiple words at once with _remove Christopher Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377646061-24208-1-git-send-email-kergoth@gmail.com \
--to=kergoth@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=chris_larson@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox