From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alex DAMIAN <alexandru.damian@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 5/8] bitbake: build: add logfile path for all Task events
Date: Mon, 16 Sep 2013 13:14:09 +0100 [thread overview]
Message-ID: <1379333649.3484.286.camel@ted> (raw)
In-Reply-To: <a5db8806dc326f93d8e0bb36ff1c7b83d1d77e6a.1379332511.git.alexandru.damian@intel.com>
On Mon, 2013-09-16 at 12:56 +0100, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> We add the path to the logfile for all Task events, so
> that we can record the logfile locations during the run.
>
> This is needed because the logfile symlinks will point
> only to the last build logs, and there is no other link
> between a certain build and the log file it produces.
>
> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> ---
> bitbake/lib/bb/build.py | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
a) you might as well modify TaskBase intead of each Task
b) You didn't fix up all the original Task* references e.g. TaskInvalid.
I gave up and merged my own version of this.
Cheers,
Richard
next prev parent reply other threads:[~2013-09-16 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 11:56 [PATCH 0/8] webhob related changes in bitbake, version 2 Alex DAMIAN
2013-09-16 11:56 ` [PATCH 1/8] bitbake: cooker: clean up code and avoid duplication Alex DAMIAN
2013-09-16 11:56 ` [PATCH 2/8] bitbake: event: send the task dependency tree to UI Alex DAMIAN
2013-09-16 11:56 ` [PATCH 3/8] bitbake: runqueue: add runQueueTaskSkipped event Alex DAMIAN
2013-09-16 11:56 ` [PATCH 4/8] bitbake: cooker: add extra recipe information Alex DAMIAN
2013-09-16 11:56 ` [PATCH 5/8] bitbake: build: add logfile path for all Task events Alex DAMIAN
2013-09-16 12:14 ` Richard Purdie [this message]
2013-09-16 11:56 ` [PATCH 6/8] bitbake: cooker, command: add a command to return global data Alex DAMIAN
2013-09-16 12:21 ` Richard Purdie
2013-09-16 11:56 ` [PATCH 7/8] bitbake: event: adding events to allow bbclasses to push custom info Alex DAMIAN
2013-09-16 11:56 ` [PATCH 8/8] bitbake: runqueue: add task hash to Queue events Alex DAMIAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379333649.3484.286.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=alexandru.damian@intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox