From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] bitbake: replace 3 spaces with 4
Date: Thu, 02 Jan 2014 13:06:42 +0000 [thread overview]
Message-ID: <1388668002.11527.100.camel@ted> (raw)
In-Reply-To: <c26d7a72feb5c465b89cbc719e97afec4a5c0892.1388159725.git.liezhi.yang@windriver.com>
On Fri, 2013-12-27 at 23:55 +0800, Robert Yang wrote:
> A part of fetch2/__init__.py and yacc.py uses 3 spaces as the indent, I
> think that they should be typos.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> bitbake/lib/bb/fetch2/__init__.py | 8 ++++----
> bitbake/lib/ply/yacc.py | 12 ++++++------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
> index 8fdf59c..439a44a 100644
> --- a/bitbake/lib/bb/fetch2/__init__.py
> +++ b/bitbake/lib/bb/fetch2/__init__.py
> @@ -1263,10 +1263,10 @@ class FetchMethod(object):
> return
>
> def clean(self, urldata, d):
> - """
> - Clean any existing full or partial download
> - """
> - bb.utils.remove(urldata.localpath)
> + """
> + Clean any existing full or partial download
> + """
> + bb.utils.remove(urldata.localpath)
>
> def try_premirror(self, urldata, d):
> """
The __init__ change is fine and I've taken it, the yacc code is actually
a copy from upstream so its better to leave that alone even if its not
entirely correct.
Cheers,
Richard
prev parent reply other threads:[~2014-01-02 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 15:55 [PATCH 0/1] bitbake: replace 3 spaces with 4 Robert Yang
2013-12-27 15:55 ` [PATCH 1/1] " Robert Yang
2014-01-02 13:06 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388668002.11527.100.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=liezhi.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox