From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [RFC PATCH 1/1] bitbake/cooker.py: set the PREFERRED_VERSION from command line
Date: Tue, 07 Jan 2014 13:18:45 +0000 [thread overview]
Message-ID: <1389100725.6899.21.camel@ted> (raw)
In-Reply-To: <4d61da4f684bc292dd35b407c2dfa9ce5e6633c4.1389005562.git.liezhi.yang@windriver.com>
On Mon, 2014-01-06 at 18:53 +0800, Robert Yang wrote:
> We can't set the PREFERRED_VERSION from the command line, this will make
> it possible:
>
> $ P_V="3.81" bitbake make
> $ P_V="3.81" bitbake make-native
>
> Then the make-3.81 and make-native-3.81 will be built (the default is
> 3.82)
>
> Another we that we have originally thought was:
>
> $ export BB_PRESERVE_ENV=1
> $ PREFERRED_VERSION_make = 3.81 bitbake make
>
> This worked for make, but didn't work for make-native since
> we can't use "-" in a shell environment variable.
>
> TODO:
> * This is just a RFC and open for discussion, any comments is
> appreciated.
>
> * It only can set the PREFERRED_VERSION for the pkg_to_build, we can
> make it more flexible, for example, if we found the keyword
> PREFERRED_VERSION in the P_V, we can set it for any recipe:
> (assume core-image-sato RDEPENDS on make)
> $ P_V="PREFERRED_VERSION_make=3.81" bitbake core-image-sato
Well, this defines a different version of PREFERRED_VERSION with
completely different semantics to the other one. I don't think this is
acceptable or a good way to avoid this problem and will ultimately just
confuse more users.
> * BTW, another questions, can we change the PREFERRED_VERSION to P_V
> or PF_V, and the PREFERRED_PROVIDER to P_P ot PF_P, please ? They are
> a little long to type and easy to make typos currently.
No, this would be extremely confusing with PV and other variables.
Please use copy and paste or something ;-).
A better way of handling things might be to translate "__" to "-" when
importing variables from the environment so you could set:
PREFERRED_VERSION_make__native = "3.81"
I'm open to other ideas but don't like P_V at all, particularly when it
behaves differently to PREFERRED_VERSION.
Cheers,
Richard
prev parent reply other threads:[~2014-01-07 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 10:53 [RFC PATCH 0/1] set the PREFERRED_VERSION from command line Robert Yang
2014-01-06 10:53 ` [RFC PATCH 1/1] bitbake/cooker.py: " Robert Yang
2014-01-07 13:18 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389100725.6899.21.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=liezhi.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox