From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: "Zongchun.Yu@freescale.com" <Zongchun.Yu@freescale.com>,
"B40290@freescale.com" <B40290@freescale.com>,
"ting.liu@freescale.com" <ting.liu@freescale.com>,
"bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>,
Richard Schmitt <richard.schmitt@freescale.com>
Subject: Re: [PATCH 1/2] bitbake: fetch2/git: Add sanity check for SHA validity of tag
Date: Wed, 08 Jan 2014 12:43:11 +0000 [thread overview]
Message-ID: <1389184991.6899.95.camel@ted> (raw)
In-Reply-To: <20140108113213.GV3709@jama>
On Wed, 2014-01-08 at 12:32 +0100, Martin Jansa wrote:
> > [Luo Zhenhua-B19537] You point is to show warning when SRCREV and tag are set, meanwhile SRCREV is not corresponding to the tag, right?
>
> Yes
We have several different issues around and the moment and I'm worried
some cases are going to get lost. We really need a list of them along
with the planed fix. As I see it we have:
a) conflicting SRCREV and tag/rev url parameters
Plan: bb.error on this case asking the user to say what they want
b) dereferencing of tags when checking existance of commits
Plan: Add ^{} to ls-remote command to allow dereferencing
c) tags may get resolved to incorrect tags in sub directories
Plan: Need to anchor tag/branch search expression
What else are we missing?
Ideally we could do with examples of these in the fetcher test code
too...
Cheers,
Richard
next prev parent reply other threads:[~2014-01-08 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 8:06 [PATCH 0/2] bitbake: fetch2: Add sanity check for SHA validity of tag and adjust SHA define order Zhenhua Luo
2013-12-24 8:06 ` [PATCH 1/2] bitbake: fetch2/git: Add sanity check for SHA validity of tag Zhenhua Luo
2014-01-03 13:43 ` Martin Jansa
2014-01-06 4:25 ` zhenhua.luo
2014-01-06 9:12 ` Martin Jansa
2014-01-07 3:29 ` zhenhua.luo
2014-01-07 14:46 ` Martin Jansa
2014-01-08 10:21 ` zhenhua.luo
2014-01-08 11:32 ` Martin Jansa
2014-01-08 12:43 ` Richard Purdie [this message]
2014-01-20 21:14 ` Richard Purdie
2013-12-24 8:06 ` [PATCH 2/2] bitbake: fetch2: adjust the priority of revision definition Zhenhua Luo
2014-01-03 2:12 ` [PATCH 0/2] bitbake: fetch2: Add sanity check for SHA validity of tag and adjust SHA define order zhenhua.luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389184991.6899.95.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=B40290@freescale.com \
--cc=Zongchun.Yu@freescale.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=martin.jansa@gmail.com \
--cc=richard.schmitt@freescale.com \
--cc=ting.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox