Re: [PATCH] fetch2: Fix bug in file checksum generation

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2014-04-06 at 12:39 +0200, Jacob Kroon wrote:
> Perhaps it would be cleaner to do 
>
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index 4335e7a..03ab234 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -979,9 +979,8 @@ def get_file_checksums(filelist, pn):
>                          checksums.append((fullpth, checksum))
>          else:
>              checksum = checksum_file(pth)
> -
> -        if checksum:
> -            checksums.append((pth, checksum))
> +            if checksum:
> +                checksums.append((pth, checksum))
>  
>      checksums.sort(key=operator.itemgetter(1))
>      return checksums
> 
> 
> or am I missing something here ?

The other patch indicates more specifically what the problem was, this
is probably the cleaner code. They amount to the same thing...

Cheers,

Richard