Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 4/4] event: fix resetting class handlers object
Date: Mon, 08 Dec 2014 20:57:48 +0000	[thread overview]
Message-ID: <1418072268.22903.27.camel@linuxfoundation.org> (raw)
In-Reply-To: <1418060539.22903.24.camel@linuxfoundation.org>

On Mon, 2014-12-08 at 17:42 +0000, Richard Purdie wrote:
> On Mon, 2014-12-08 at 10:50 +0000, Paul Eggleton wrote:
> > If you don't explicitly specify to use a global variable when doing an
> > assignment, you will be setting a local variable instead, which means
> > this function wasn't working at all. It explains some odd behaviour we
> > have seen in the layer index where event handlers were sometimes
> > bleeding into other contexts where they should not have been.
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> >  lib/bb/event.py | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/bb/event.py b/lib/bb/event.py
> > index 9645476..8bc6b80 100644
> > --- a/lib/bb/event.py
> > +++ b/lib/bb/event.py
> > @@ -55,6 +55,7 @@ def get_class_handlers():
> >      return _handlers
> >  
> >  def set_class_handlers(h):
> > +    global handlers
> >      _handlers = h
> 
> Er, shouldn't this be _handlers?

I put the patch in master-next and tweaked this.

Cheers,

Richard



      parent reply	other threads:[~2014-12-08 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 10:50 [PATCH 0/4] Developer workflow related enhancements / fixes Paul Eggleton
2014-12-08 10:50 ` [PATCH 1/4] utils: add exec_flat_python_func() Paul Eggleton
2014-12-08 10:50 ` [PATCH 2/4] fetch2: add means of disabling SRC_URI checksums Paul Eggleton
2014-12-08 10:50 ` [PATCH 3/4] event: add a means of filtering events internally Paul Eggleton
2014-12-08 10:50 ` [PATCH 4/4] event: fix resetting class handlers object Paul Eggleton
2014-12-08 17:42   ` Richard Purdie
2014-12-08 18:09     ` Paul Eggleton
2014-12-08 20:57     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418072268.22903.27.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox