Re: [PATCH 1/1] bitbake: prserv/serv: sync database after thead quit

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2015-01-19 at 16:48 +0800, Chong Lu wrote:
> We need sync database after thread quit, else we may get a empty table
> after import a PR database.
> 
> [YOCTO #6752]
> 
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>  bitbake/lib/prserv/serv.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py
> index 25eb46a..c774c5e 100644
> --- a/bitbake/lib/prserv/serv.py
> +++ b/bitbake/lib/prserv/serv.py
> @@ -87,7 +87,7 @@ class PRServer(SimpleXMLRPCServer):
>                  self.finish_request(request, client_address)
>                  self.shutdown_request(request)
>                  iter_count = (iter_count + 1) % iterations_between_sync
> -                if iter_count == 0:
> +                if iter_count == 0 or self.quit:
>                      self.table.sync_if_dirty()
>              except:
>                  self.handle_error(request, client_address)

Thanks for the patch. I had a look at this problem and I think there are
bigger problems with the code. Can you take a look at the patch I've
just posted, it should solve this issue as well as several others.

Cheers,

Richard