From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] git.py: create a branch when checkout
Date: Tue, 07 Jul 2015 16:17:42 +0100 [thread overview]
Message-ID: <1436282262.27597.183.camel@linuxfoundation.org> (raw)
In-Reply-To: <fc82e0723a4877cdcd92e97cd2cf19f4a5d0ff70.1436232786.git.liezhi.yang@windriver.com>
On Mon, 2015-07-06 at 18:33 -0700, Robert Yang wrote:
> Create a branch named oebuild_SRCREV when checkout the source, this
> makes debug easier than "(no branch)" when look into the source.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> bitbake/lib/bb/fetch2/git.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
> index 2e53882..12087dd 100644
> --- a/bitbake/lib/bb/fetch2/git.py
> +++ b/bitbake/lib/bb/fetch2/git.py
> @@ -280,7 +280,8 @@ class Git(FetchMethod):
> runfetchcmd("%s read-tree %s%s" % (ud.basecmd, ud.revisions[ud.names[0]], readpathspec), d)
> runfetchcmd("%s checkout-index -q -f -a" % ud.basecmd, d)
> else:
> - runfetchcmd("%s checkout %s" % (ud.basecmd, ud.revisions[ud.names[0]]), d)
> + runfetchcmd("%s checkout %s -b oebuild_%s" % (ud.basecmd, \
> + ud.revisions[ud.names[0]], ud.revisions[ud.names[0]]), d)
> return True
Would it not make more sense to set the branch to the upstream branch
name here?
Cheers,
Richard
next prev parent reply other threads:[~2015-07-07 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 1:33 [PATCH 0/1] git.py: create a branch when checkout Robert Yang
2015-07-07 1:33 ` [PATCH 1/1] " Robert Yang
2015-07-07 15:17 ` Richard Purdie [this message]
2015-07-07 16:56 ` Paul Eggleton
2015-07-08 1:28 ` Robert Yang
2015-07-08 8:28 ` Richard Purdie
2015-07-09 5:57 ` Robert Yang
-- strict thread matches above, loose matches on Subject: below --
2015-07-09 7:18 [PATCH 0/1 V2] " Robert Yang
2015-07-09 7:18 ` [PATCH 1/1] " Robert Yang
2015-07-09 16:54 ` Paul Eggleton
2015-07-10 0:00 ` Robert Yang
2015-07-10 9:04 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436282262.27597.183.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=liezhi.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox