From: Olof Johansson <olof.johansson@axis.com>
To: Michael Wood <michael.g.wood@intel.com>,
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH 12/14] bitbake: toaster logger: fix pylint issues
Date: Thu, 20 Aug 2015 14:55:12 +0200 [thread overview]
Message-ID: <1440074510-sup-9447@axis.com> (raw)
In-Reply-To: <6327c2465f573e6332219c62c1a9b3d8323cfb50.1439915029.git.michael.g.wood@intel.com>
Excerpts from Michael Wood's message of 2015-08-18 18:28:58 +0200:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> This patch fixes pylint issues in the toaster build data logger,
> toasterui. The following types of warnings are touched here:
>
> * fixing imports
> * unused variables are set to _
> * logger calls now use lazy evaluation instead of formatting
> the string
> * correct whitespace identation
> * removes unneeded "pass" statements, and extra parantheses
> * disable specific pylint warnings when decideing to override
> them
This change causes the following RuntimeError exception, when running bitbake
(any bitbake command):
$ python --version
Python 2.7.9
$ bitbake
Traceback (most recent call last):
File ".../poky/bitbake/bin/bitbake", line 44, in <module>
sys.exit(bitbake_main(BitBakeConfigParameters(sys.argv),
File ".../poky/bitbake/lib/bb/cookerdata.py", line 37, in __init__
self.options, targets = self.parseCommandLine(argv)
File ".../poky/bitbake/lib/bb/main.py", line 178, in parseCommandLine
valid_uis = list_extension_modules(bb.ui, 'main')
File ".../poky/bitbake/lib/bb/main.py", line 62, in list_extension_modules
module = __import__(pkg.__name__, fromlist=[modulename])
File ".../poky/bitbake/lib/bb/ui/buildinfohelper.py", line 44, in <module>
from bldcontrol.models import BuildEnvironment, BuildRequest
File ".../poky/bitbake/lib/toaster/bldcontrol/models.py", line 3, in <module>
from orm.models import Project, ProjectLayer, ProjectVariable, ProjectTarget, Build
File ".../poky/bitbake/lib/toaster/orm/models.py", line 56, in <module>
class ToasterSetting(models.Model):
File "/usr/lib/python2.7/dist-packages/django/db/models/base.py", line 283, in __new__
new_class._meta.apps.register_model(new_class._meta.app_label, new_class)
File "/usr/lib/python2.7/dist-packages/django/apps/registry.py", line 221, in register_model
(model_name, app_label, app_models[model_name], model))
RuntimeError: Conflicting 'toastersetting' models in application 'orm': <class 'toaster.orm.models.ToasterSetting'> and <class 'orm.models.ToasterSetting'>.
Even though .../poky/bitbake/lib is already in the sys.path,
.../poky/bitbake/lib/toaster is also added, which seem to be the cause of this
issue.
I'm a bit surprised that this kind of change causes issues for use of bitbake
not related to toaster.
--
olof johansson
next prev parent reply other threads:[~2015-08-20 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 16:28 [PATCH 00/14] Toaster patches Michael Wood
2015-08-18 16:28 ` [PATCH 01/14] bitbake: toaster: pylint fixes Michael Wood
2015-08-18 16:28 ` [PATCH 02/14] bitbake: toaster: checksettings: fix guesspath initialization Michael Wood
2015-08-18 16:28 ` [PATCH 03/14] bitbake: toaster: checksettings: fix TEMPLATECONF detection Michael Wood
2015-08-18 16:28 ` [PATCH 04/14] bitbake: toaster: improve exception handling Michael Wood
2015-08-18 16:28 ` [PATCH 05/14] bitbake: toaster: models field initialization Michael Wood
2015-08-18 16:28 ` [PATCH 06/14] bitbake: toaster: use loggers instead of prints Michael Wood
2015-08-18 16:28 ` [PATCH 07/14] bitbake: toastergui: rename variables in views.py Michael Wood
2015-08-18 16:28 ` [PATCH 08/14] bitbake: toaster: do not stop data import on bad data Michael Wood
2015-08-18 16:28 ` [PATCH 09/14] bitbake: toaster: replace raising Exceptions in loadconf Michael Wood
2015-08-18 16:28 ` [PATCH 10/14] bitbake: toaster: fix updates on failed build requests Michael Wood
2015-08-18 16:28 ` [PATCH 11/14] bitbake: toaster: fix pylint errors Michael Wood
2015-08-18 16:28 ` [PATCH 12/14] bitbake: toaster logger: fix pylint issues Michael Wood
2015-08-20 12:55 ` Olof Johansson [this message]
2015-08-20 21:06 ` Richard Purdie
2015-08-18 16:28 ` [PATCH 13/14] toastergui: do not show in-progress builds in the table Michael Wood
2015-08-18 16:29 ` [PATCH 14/14] toastergui: fix projectbuilds page Michael Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440074510-sup-9447@axis.com \
--to=olof.johansson@axis.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=michael.g.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).