From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: Alex Franco <alejandro.franco@linux.intel.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] Allow bitbake commands starting with do_
Date: Mon, 31 Aug 2015 18:35:09 -0500 [thread overview]
Message-ID: <1441064109.3828.5.camel@linux.intel.com> (raw)
In-Reply-To: <1441041701-27060-1-git-send-email-alejandro.franco@linux.intel.com>
I like this version from the 3 you sent today :) See comment below
On Mon, 2015-08-31 at 12:21 -0500, Alex Franco wrote:
> The output of "bitbake, -c listtasks pkg" lists tasks with their real
> names
> (starting with "do_"), but then "bitbake -c do_task" fails, as "do_"
> always
> gets unconditionally prepended to task names. This patch handles this
> error
> by always removing "do_" from the beginning of task names when the
> runqueue
> is being constructed.
>
> [YOCTO #7818]
>
> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
> ---
> bitbake/lib/bb/runqueue.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
> index 0f99e5a..4a0f01a 100644
> --- a/bitbake/lib/bb/runqueue.py
> +++ b/bitbake/lib/bb/runqueue.py
> @@ -634,6 +634,10 @@ class RunQueueData:
>
> fnid = taskData.build_targets[targetid][0]
> fn = taskData.fn_index[fnid]
> +
imports at this point sometimes get messy, would be good if it was at
least at the beginning of the function.
> + import re
> + target[1] = re.sub("^do_", "", target[1])
> +
> self.target_pairs.append((fn, target[1]))
>
> if fnid in taskData.failed_fnids:
prev parent reply other threads:[~2015-09-01 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 17:21 [PATCH] Allow bitbake commands starting with do_ Alex Franco
2015-08-31 17:34 ` Christopher Larson
2015-08-31 23:35 ` Benjamin Esquivel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441064109.3828.5.camel@linux.intel.com \
--to=benjamin.esquivel@linux.intel.com \
--cc=alejandro.franco@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox