Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: brian avery <avery.brian@gmail.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 2/5] toaster: Add tests for /project/X/builds page
Date: Wed, 16 Sep 2015 22:10:42 +0100	[thread overview]
Message-ID: <1442437842.26666.179.camel@linuxfoundation.org> (raw)
In-Reply-To: <fa4a3965a75c8b3c659d7bdce1f5949a2f6f046b.1441904599.git.avery.brian@gmail.com>

On Thu, 2015-09-10 at 10:05 -0700, brian avery wrote:
> From: Elliot Smith <elliot.smith@intel.com>
> 
> Add tests to check whether "in progress" builds are filtered
> out correctly, and that only builds for the current project
> are shown.
> 
> Adds a dependency on BeautifulSoup 4, which is used to simplify
> writing tests which verify the HTML.
> 
> Also requires a fix to how a date was converted in the view
> which only manifested when I wrote the tests.
> 
> [YOCTO #8236]
> [YOCTO #8187]
> 
> Signed-off-by: Elliot Smith <elliot.smith@intel.com>
> Signed-off-by: brian avery <avery.brian@gmail.com>

Could you rebase this patch and point me at a branch please. I can't
seem to get it to apply cleanly. I did get the others to work with line
offset warnings.

Cheers,

Richard



  reply	other threads:[~2015-09-16 21:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 17:05 [PATCH 0/5] Hide irrelevant builds brian avery
2015-09-10 17:05 ` Brian Avery
2015-09-10 17:05 ` [PATCH 1/5] toaster: hide irrelevant builds in the project builds view brian avery
2015-09-10 17:05 ` [PATCH 2/5] toaster: Add tests for /project/X/builds page brian avery
2015-09-16 21:10   ` Richard Purdie [this message]
2015-09-17  8:09     ` Smith, Elliot
2015-09-19 10:33       ` Richard Purdie
2015-09-10 17:05 ` [PATCH 3/5] toaster: Show correct builds count on project pages brian avery
2015-09-10 17:05 ` [PATCH 4/5] toaster: Fix date range pickers on the project builds page brian avery
2015-09-10 17:05 ` [PATCH 5/5] toaster: Simplify redirects when build page parameters are missing brian avery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442437842.26666.179.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=avery.brian@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox