From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Elliot Smith <elliot.smith@intel.com>,
"Bartosh, Eduard" <eduard.bartosh@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/6] event: add new property to BuildBase class
Date: Sun, 11 Oct 2015 05:22:10 +0100 [thread overview]
Message-ID: <1444537330.14364.5.camel@linuxfoundation.org> (raw)
In-Reply-To: <04c22e69056969f61173107062a4eec82a4bc3ed.1444038048.git.elliot.smith@intel.com>
On Mon, 2015-10-05 at 10:43 +0100, Elliot Smith wrote:
> From: Ed Bartosh <ed.bartosh@linux.intel.com>
>
> Added 'task' property to the base class of BuildStarted and
> BuildCompleted classes to store bitbake task if it's specified.
>
> This is done as without task Build* events can't fully represent
> bitbake build. Task information is needed by UI classes to properly
> show or process Build* events.
This doesn't make sense I'm afraid. There is no one "task" which a build
start/complete event can correspond to. Consider something like:
"bitbake A:do_fetch B:do_rootfs"
There would be one BuildStarted event but task doesn't have a singular
value. We therefore don't want to add task information to these events
as it will ultimately mislead anything building on top of this
information.
I appreciate there is the -c option, but that just means "if there is no
specific task specified, use this", i.e. its a default.
Cheers,
Richard
next prev parent reply other threads:[~2015-10-11 4:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 9:43 [PATCH 0/6] Fixes for toastergui Elliot Smith
2015-10-05 9:43 ` [PATCH 1/6] event: add new property to BuildBase class Elliot Smith
2015-10-11 4:22 ` Richard Purdie [this message]
2015-10-11 20:02 ` Ed Bartosh
2015-10-12 4:54 ` Richard Purdie
2015-10-13 8:33 ` Ed Bartosh
2015-10-14 8:41 ` [PATCH] bitbake: normalize build targets Ed Bartosh
2015-10-14 22:20 ` Christopher Larson
2015-10-15 8:37 ` [PATCH v2] " Ed Bartosh
2015-10-16 13:09 ` Richard Purdie
2015-10-05 9:43 ` [PATCH 2/6] event: add new parameter to Build* event APIs Elliot Smith
2015-10-05 9:43 ` [PATCH 3/6] toaster: add task to the target_information Elliot Smith
2015-10-05 9:43 ` [PATCH 4/6] toaster: add get_or_create_targets API Elliot Smith
2015-10-05 9:43 ` [PATCH 5/6] toaster: ignore ReachableStamps event Elliot Smith
2015-10-05 9:43 ` [PATCH 6/6] toaster: use meaningful logging levels Elliot Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444537330.14364.5.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=eduard.bartosh@intel.com \
--cc=elliot.smith@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox