From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Christopher Larson <clarson@kergoth.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] cookerdata: Fix log messages and ensure we exit
Date: Thu, 12 May 2016 16:11:26 +0100 [thread overview]
Message-ID: <1463065886.9746.14.camel@linuxfoundation.org> (raw)
In-Reply-To: <CABcZAN=v9YiLHPQugxLXpOKbznSjek30Xbk72+9-BF6bPiyLOQ@mail.gmail.com>
On Thu, 2016-05-12 at 07:55 -0700, Christopher Larson wrote:
>
> On Thu, May 12, 2016 at 2:56 AM, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > The string formatting wasn't correct and we should exit if we hit
> > errors here similar to the other exception handlers.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >
> > diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> > index 50259a9..fba95af 100644
> > --- a/lib/bb/cookerdata.py
> > +++ b/lib/bb/cookerdata.py
> > @@ -192,7 +192,8 @@ def catch_parse_error(func):
> > fn, _, _, _ = traceback.extract_tb(tb, 1)[0]
> > if not fn.startswith(bbdir):
> > break
> > - parselog.critical("Unable to parse %s", fn,
> > exc_info=(exc_class, exc, tb))
> > + parselog.critical("Unable to parse %s" % fn,
> > exc_info=(exc_class, exc, tb))
> > + sys.exit(1)
> >
> The python logging module supports passing the % format values as
> arguments, you don't have to format the string at call time. What was
> the error here?
I had a whole load of debug here and distilled it down to this as it
looked inconsistent with the rest of our code. Its possible the real
problem was with exc_info as mentioned in another patch...
Cheers,
Richard
prev parent reply other threads:[~2016-05-12 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 9:56 [PATCH] cookerdata: Fix log messages and ensure we exit Richard Purdie
2016-05-12 14:55 ` Christopher Larson
2016-05-12 15:11 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463065886.9746.14.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox