Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patrick Ohly <patrick.ohly@intel.com>,
	bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] runqueue.py: always emit bb.event.DepTreeGenerated
Date: Sun, 15 May 2016 09:15:42 +0100	[thread overview]
Message-ID: <1463300142.9746.154.camel@linuxfoundation.org> (raw)
In-Reply-To: <1463065210-3823-1-git-send-email-patrick.ohly@intel.com>

On Thu, 2016-05-12 at 17:00 +0200, Patrick Ohly wrote:
> The data included in the event is useful for implementing a pre-build
> check that warns about unexpected components, for example because of
> an incorrect configuration or changed dependencies.
> 
> Such a check can be done in a .bbclass that gets inherited
> globally. But in contrast to a UI, such a class cannot request that
> the event shall be emitted, and thus the event has to be emitted
> whether there is a consumer or not.
> 
> This was done conditionally earlier out of concerns about the
> performance impact. But now events are handled more efficiently, so
> that concern no longer seems valid: in some simple testing
> (admittedly
> on a fast build workstation), the two lines (generating the data and
> emitting the event with it) only took about 0.05 seconds (measured
> with timeit). That was for a build with roughly 500 recipes (from
> pn-buildlist aka depgraph['pn']), triggered via the command line.
> That
> was even with a consumer of the data active and doing some work, so
> it
> should be even faster when there is no consumer.

I've taken this since now we have event filtering, we don't take the
IPC/RPC cost for data that the receiver doesn't care about. I added a
follow up patch which removes the feature entirely since this code
block was the only reason for it.

Cheers,

Richard


  reply	other threads:[~2016-05-15  8:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 15:00 [PATCH] runqueue.py: always emit bb.event.DepTreeGenerated Patrick Ohly
2016-05-15  8:15 ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-05-12 13:58 Patrick Ohly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463300142.9746.154.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=patrick.ohly@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox