Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 10/10] runqueue: report progress for "Preparing RunQueue" step
Date: Wed, 15 Jun 2016 22:46:41 +0100	[thread overview]
Message-ID: <1466027201.13979.240.camel@linuxfoundation.org> (raw)
In-Reply-To: <1951483.CXMg640ZQm@peggleto-mobl.ger.corp.intel.com>

On Tue, 2016-06-14 at 00:16 +1200, Paul Eggleton wrote:
> On Mon, 13 Jun 2016 12:09:33 Richard Purdie wrote:
> > On Mon, 2016-06-13 at 14:52 +1200, Paul Eggleton wrote:
> > > @@ -1119,14 +1150,19 @@ class RunQueue:
> > >          if self.state is runQueuePrepare:
> > >              self.rqexe = RunQueueExecuteDummy(self)
> > > 
> > > +            self.rqdata.init_progress_reporter =
> > > bb.progress.MultiStageProcessProgressReporter(self.cooker.data, +
> > >         
> > >                                                    "Initialising
> > > tasks",
> > > +                                                            [27,
> > > 870, 3,
> > > 33, 1, 3, 3, 2, 3, 6, 1, 13, 1, 1, 132, 32, 1, 61, 1, 13, 2, 243,
> > > 151,
> > > 299, 81, 1, 15, 72])> 
> > >              if self.rqdata.prepare() == 0:
> > >                  self.state = runQueueComplete
> > >              
> > >              else:
> > >                  self.state = runQueueSceneInit
> > > 
> > > +                self.rqdata.init_progress_reporter.next_stage()
> > 
> > I appreciate the difficulty in figuring some of this out and the
> > changes look quite neat on the most part. I am however very worried
> > by
> > the above from a code maintenance standpoint.
> > 
> > If for example I add or remove a step in runqueue, how do I know
> > where
> > in this array to make a change? How do I calculate what the new
> > weighting should be?
> 
> Actually with the current patchset it's pretty easy. Just temporarily
> specify 
> debug=True to the reporter when constructing and it will print out
> the list of 
> weightings (based on timing each stage) when finish() is called,
> along with a 
> map of the weightings to the lines where next_stage() was called.
> (Perhaps if 
> we'd want a comment to that effect for anyone editing this code.)

I think a comment in there about this would be helpful as it isn't
clear how to handle this. What does it do in the case you have a next()
call without a weight? Will that give a warning?

Cheers,

Richard


  reply	other threads:[~2016-06-15 21:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13  2:52 [PATCH 00/10] Support progress reporting Paul Eggleton
2016-06-13  2:52 ` [PATCH 01/10] knotty: provide a symlink to the latest console log Paul Eggleton
2016-06-13  2:52 ` [PATCH 02/10] knotty: import latest python-progressbar Paul Eggleton
2016-06-13  2:52 ` [PATCH 03/10] lib: implement basic task progress support Paul Eggleton
2016-06-13  2:52 ` [PATCH 04/10] lib/bb/progress: add MultiStageProgressReporter Paul Eggleton
2016-06-13  2:52 ` [PATCH 05/10] fetch2: implement progress support Paul Eggleton
2016-06-28 10:23   ` Burton, Ross
2016-06-28 10:33     ` Paul Eggleton
2016-06-13  2:52 ` [PATCH 06/10] knotty: add code to support showing progress for sstate object querying Paul Eggleton
2016-06-13  2:52 ` [PATCH 07/10] knotty: show task progress bar Paul Eggleton
2016-06-13  2:52 ` [PATCH 08/10] knotty: add quiet output mode Paul Eggleton
2016-06-13  2:52 ` [PATCH 09/10] runqueue: add ability to enforce that tasks are setscened Paul Eggleton
2016-06-13  2:52 ` [PATCH 10/10] runqueue: report progress for "Preparing RunQueue" step Paul Eggleton
2016-06-13 11:09   ` Richard Purdie
2016-06-13 12:16     ` Paul Eggleton
2016-06-15 21:46       ` Richard Purdie [this message]
2016-06-15 21:49         ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466027201.13979.240.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox