Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 2/2] bitbake: implement checksums for local files in SRC_URI
Date: Wed, 23 May 2012 00:50:48 +0100	[thread overview]
Message-ID: <1486170.3Ec8bBqrfQ@helios> (raw)
In-Reply-To: <4FBC2513.4090607@windriver.com>

On Tuesday 22 May 2012 18:45:23 you wrote:
> On 5/22/12 6:23 PM, Paul Eggleton wrote:
> > Gathers a list of paths to have checksums calculated at parse time, and
> > processes these when calculating task hashes. Checksums are cached with
> > the file's current mtime. Thus, changing any local file in SRC_URI will
> > now cause the do_fetch taskhash to change, thus forcing a rebuild.
> 
> Does the mtime change invalidate the checksum, or just cause the checksum to
> be re-interpreted?

The latter.

> The issue I see is that you share a ccache file with someone else, their
> files may simply have a different mtime on them.

I'm guessing s/ccache/sstate cache/ ?

This will be fine - only the checksum of the file contents goes into the sstate 
signature.

>  From reading the code below, I think the comment is just confusing me.  The
> checksum is computed and stored bases on a hash + mtime.  If the mtime
> changes, that will cause the system to recalculate the checksum, which may
> end up being the same.. (and if it is, no rebuild) right?

Correct.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2012-05-23  0:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 23:23 [PATCH 0/2] Implement file checksums Paul Eggleton
2012-05-22 23:23 ` [PATCH 1/2] bitbake: refactor out codeparser cache into a separate class Paul Eggleton
2012-05-22 23:23 ` [PATCH 2/2] bitbake: implement checksums for local files in SRC_URI Paul Eggleton
2012-05-22 23:45   ` Mark Hatle
2012-05-22 23:50     ` Paul Eggleton [this message]
2012-05-22 23:55       ` Paul Eggleton
2012-05-23  9:42         ` Richard Purdie
2012-05-23 10:25 ` [PATCH 0/2] Implement file checksums Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486170.3Ec8bBqrfQ@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=mark.hatle@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox