From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Cc: Phoong Stanley Cheong Kwan <stanley.cheong.kwan.phoong@intel.com>,
Bitbake dev Mailing List <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] bitbake-layers: check layer dependencies before adding
Date: Fri, 26 May 2017 08:39:15 -0500 [thread overview]
Message-ID: <1495805955.26945.13.camel@linux.intel.com> (raw)
In-Reply-To: <1495765159-172739-1-git-send-email-rebecca.swee.fun.chang@intel.com>
On Fri, 2017-05-26 at 10:19 +0800, Chang Rebecca Swee Fun wrote:
> + self.tinfoil.parseRecipes()
> + except bb.tinfoil.TinfoilUIException:
> + # Restore the back up copy of bblayers.conf
> + shutil.copy2(backup, bblayers_conf)
> + bb.fatal("Parse failure with the specified layer added")
AFAIK, bb.fatal raises an exception, so the return 1 is not needed.
> + return 1
> + else:
> + for item in notadded:
> + sys.stderr.write("Specified layer %s is already in BBLAYERS\n" % item)
> + finally:
> + # Remove the back up copy of bblayers.conf
> + shutil.rmtree(tempdir)
>
> def do_remove_layer(self, args):
> """Remove a layer from bblayers.conf."""
> --
> 2.7.4
>
prev parent reply other threads:[~2017-05-26 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 2:19 [PATCH] bitbake-layers: check layer dependencies before adding Chang Rebecca Swee Fun
2017-05-26 13:39 ` Leonardo Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495805955.26945.13.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=rebecca.swee.fun.chang@intel.com \
--cc=stanley.cheong.kwan.phoong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox