From: "Belal, Awais" <Awais_Belal@mentor.com>
To: "Reyna, David" <david.reyna@windriver.com>,
"bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH v2] bitbake: toaster: allow OE_ROOT to be provided through environment
Date: Thu, 8 Nov 2018 06:24:08 +0000 [thread overview]
Message-ID: <1541658246944.14342@mentor.com> (raw)
In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D0F3B29466@ALA-MBD.corp.ad.wrs.com>
Ping! Can we get this into sumo?
BR,
Awais
________________________________________
From: Reyna, David <david.reyna@windriver.com>
Sent: Friday, November 2, 2018 6:18 AM
To: Belal, Awais; bitbake-devel@lists.openembedded.org
Subject: RE: [bitbake-devel] [PATCH v2] bitbake: toaster: allow OE_ROOT to be provided through environment
Looks good to me!
- David
-----Original Message-----
From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of Awais Belal
Sent: Thursday, November 01, 2018 2:40 PM
To: bitbake-devel@lists.openembedded.org
Subject: [bitbake-devel] [PATCH v2] bitbake: toaster: allow OE_ROOT to be provided through environment
Updates for YOCTO #12891 allowed a user to have a directory
structure different to that of yocto (bitbake isn't inside
oe-core) whereas the definition of OE_ROOT in the main toaster
binary still assumes the same while checking for .templateconf
and hence we see an error on the cmdline in such cases:
bash: <repo-path>/bitbake/bin/../../.templateconf: No such file or directory
The change here now allows the user to provide OE_ROOT through
the environment in such cases and otherwise defaults to the older
mechanism to fix this issue.
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
bin/toaster | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bin/toaster b/bin/toaster
index 9fffbc6..ecf66fa 100755
--- a/bin/toaster
+++ b/bin/toaster
@@ -161,7 +161,9 @@ fi
export BBBASEDIR=`dirname $TOASTER`/..
MANAGE="python3 $BBBASEDIR/lib/toaster/manage.py"
-OE_ROOT=`dirname $TOASTER`/../..
+if [ -z "$OE_ROOT" ]; then
+ OE_ROOT=`dirname $TOASTER`/../..
+fi
# this is the configuraton file we are using for toaster
# we are using the same logic that oe-setup-builddir uses
--
2.7.4
--
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/bitbake-devel
prev parent reply other threads:[~2018-11-08 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 21:40 [PATCH v2] bitbake: toaster: allow OE_ROOT to be provided through environment Awais Belal
2018-11-02 1:18 ` Reyna, David
2018-11-08 6:24 ` Belal, Awais [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541658246944.14342@mentor.com \
--to=awais_belal@mentor.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=david.reyna@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox