Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: git@git.openembedded.org
To: bitbake-devel@lists.openembedded.org
Subject: Christopher Larson : codeparser: make var_expands actually hold useful information
Date: Fri, 28 Oct 2011 05:52:29 +0000 (UTC)	[thread overview]
Message-ID: <20111028055229.D353B10329@opal> (raw)

Module: bitbake.git
Branch: master
Commit: 8e4e75383e43d6da2c16ec5286186a0d0569b0f8
URL:    http://git.openembedded.org/?p=bitbake.git&a=commit;h=8e4e75383e43d6da2c16ec5286186a0d0569b0f8

Author: Christopher Larson <kergoth@gmail.com>
Date:   Thu Oct 27 22:45:04 2011 -0700

codeparser: make var_expands actually hold useful information

Previously, it was calling var_expands.update() rather than add(), with
a string argument, resulting in adding each character of that string to
the var_expands set, rather than the string itself.

Signed-off-by: Christopher Larson <kergoth@gmail.com>

---

 lib/bb/codeparser.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/bb/codeparser.py b/lib/bb/codeparser.py
index 83bbb92..0dd9a36 100644
--- a/lib/bb/codeparser.py
+++ b/lib/bb/codeparser.py
@@ -227,7 +227,7 @@ class PythonParser():
             elif self.compare_name(self.expands, node.func):
                 if isinstance(node.args[0], ast.Str):
                     self.warn(node.func, node.args[0])
-                    self.var_expands.update(node.args[0].s)
+                    self.var_expands.add(node.args[0].s)
                 elif isinstance(node.args[0], ast.Call) and \
                      self.compare_name(self.getvars, node.args[0].func):
                     pass




                 reply	other threads:[~2011-10-28  5:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111028055229.D353B10329@opal \
    --to=git@git.openembedded.org \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox