From: git@git.openembedded.org
To: bitbake-devel@lists.openembedded.org
Subject: Matthew McClintock : siggen.py: If both sigs have a variable in it' s whitelist then don't say it's changed
Date: Mon, 5 Dec 2011 16:21:24 +0000 (UTC) [thread overview]
Message-ID: <20111205162124.203361032F@opal> (raw)
Module: bitbake.git
Branch: master
Commit: 71b53a3f0766ca464560a1f6a449f9424fbdf7ae
URL: http://git.openembedded.org/?p=bitbake.git&a=commit;h=71b53a3f0766ca464560a1f6a449f9424fbdf7ae
Author: Matthew McClintock <msm@freescale.com>
Date: Wed Nov 30 11:24:55 2011 -0600
siggen.py: If both sigs have a variable in it's whitelist then don't say it's changed
Some BB_HASHBASE_WHITELIST variables are in the lists of variable
dependencies for signatures. Ignore those differences in lists
since this difference does not matter
Signed-off-by: Matthew McClintock <msm@freescale.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/siggen.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index 8d768ce..22417b9 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -236,13 +236,13 @@ def compare_sigfiles(a, b):
p2 = pickle.Unpickler(file(b, "rb"))
b_data = p2.load()
- def dict_diff(a, b):
+ def dict_diff(a, b, whitelist=set()):
sa = set(a.keys())
sb = set(b.keys())
common = sa & sb
changed = set()
for i in common:
- if a[i] != b[i]:
+ if a[i] != b[i] and i not in whitelist:
changed.add(i)
added = sa - sb
removed = sb - sa
@@ -262,7 +262,7 @@ def compare_sigfiles(a, b):
if a_data['basehash'] != b_data['basehash']:
print "basehash changed from %s to %s" % (a_data['basehash'], b_data['basehash'])
- changed, added, removed = dict_diff(a_data['gendeps'], b_data['gendeps'])
+ changed, added, removed = dict_diff(a_data['gendeps'], b_data['gendeps'], a_data['basewhitelist'] & b_data['basewhitelist'])
if changed:
for dep in changed:
print "List of dependencies for variable %s changed from %s to %s" % (dep, a_data['gendeps'][dep], b_data['gendeps'][dep])
reply other threads:[~2011-12-05 16:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205162124.203361032F@opal \
--to=git@git.openembedded.org \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox