From: Olof Johansson <olof.johansson@axis.com>
To: "bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH v2 0/6] fetch2: Updated SFTP fetcher
Date: Wed, 30 Jan 2013 08:55:56 +0100 [thread overview]
Message-ID: <20130130075555.GA7508@axis.com> (raw)
In-Reply-To: <1359445811-6394-1-git-send-email-olof.johansson@axis.com>
Hi,
On 2013-01-29 08:50, Olof Johansson wrote:
> Olof Johansson (6):
> fetch2: Remove unused code in wget fetcher
> fetch2: Add a class representing a generic URI
> fetch2: unittests for bb.fetch2.URI class
> fetch2: Adapt encode/decode url to use URI class
> fetch2: Add editor modelines for bb.tests.*
> fetch2: Add SFTP fetcher
One thing I forgot to mention; after speaking with kergoth on IRC
last Friday, we found that there are some performance penelties
in using the URI class instead of encode/decodeurl. I tried to
profile and see if there were any obvious ways to get it down to
the level of the old encode/decodeurl, but nothing obvious.
I did the performance evaluation by running the unittests.
Forking and running the unittests in seperate processes shows no
change:
http://codepad.org/SYsVsckY
However, running them in a single process with the timeit module
shows a pretty big (proportional) regression:
http://codepad.org/Vzu7Pqqw
Is this significant? Running the tests 10000, each run creating
three URI objects, takes ~2 seconds.
--
Olof Johasnson
next prev parent reply other threads:[~2013-01-30 8:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 9:17 [PATCH 0/6] fetch2: SFTP fetcher and restructure of decodeurl Olof Johansson
2013-01-21 9:17 ` [PATCH 1/6] fetch2: Remove unused code in wget fetcher Olof Johansson
2013-01-21 9:17 ` [PATCH 2/6] fetch2: Add a class representing a generic URI Olof Johansson
2013-01-21 9:18 ` [PATCH 3/6] fetch2: unittests for bb.fetch2.URI class Olof Johansson
2013-01-21 9:18 ` [PATCH 4/6] fetch2: Adapt encode/decode url to use URI class Olof Johansson
2013-01-21 9:18 ` [PATCH 5/6] fetch2: Add editor modelines for bb.tests.* Olof Johansson
2013-01-21 9:18 ` [PATCH 6/6] fetch2: Add SFTP fetcher Olof Johansson
2013-01-28 14:13 ` Martin Jansa
2013-01-28 14:20 ` Olof Johansson
2013-01-28 15:43 ` Martin Jansa
2013-01-28 14:05 ` [PATCH 0/6] fetch2: SFTP fetcher and restructure of decodeurl Martin Jansa
2013-01-28 14:23 ` Olof Johansson
2013-01-29 7:50 ` [PATCH v2 0/6] fetch2: Updated SFTP fetcher Olof Johansson
2013-01-30 7:55 ` Olof Johansson [this message]
2013-01-31 12:43 ` Richard Purdie
2013-02-01 8:58 ` Peter Kjellerstedt
2013-01-29 7:50 ` [PATCH v2 1/6] fetch2: Remove unused code in wget fetcher Olof Johansson
2013-01-29 7:50 ` [PATCH v2 2/6] fetch2: Add a class representing a generic URI Olof Johansson
2013-01-29 7:50 ` [PATCH v2 3/6] fetch2: unittests for bb.fetch2.URI class Olof Johansson
2013-01-29 7:50 ` [PATCH v2 4/6] fetch2: Adapt encode/decode url to use URI class Olof Johansson
2013-02-20 7:12 ` Richard Purdie
2013-01-29 7:50 ` [PATCH v2 5/6] fetch2: Add editor modelines for bb.tests.* Olof Johansson
2013-01-29 7:50 ` [PATCH v2 6/6] fetch2: Add SFTP fetcher Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130075555.GA7508@axis.com \
--to=olof.johansson@axis.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox