Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Olof Johansson <olof.johansson@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: "bitbake-devel@lists.openembedded.org"
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [RFC 3/5] bb.tests.fetch_git: initial set of tests for git fetcher
Date: Wed, 18 Dec 2013 12:51:20 +0100	[thread overview]
Message-ID: <20131218115120.GM31548@axis.com> (raw)
In-Reply-To: <1387367036.6402.37.camel@ted>

On 13-12-18 12:43 +0100, Richard Purdie wrote:
> > +import unittest
> > +from mock import Mock, patch
> 
> This is going to cause some headaches since we don't have Mock listed in
> and of the prerequisite documentation, nor is it present in our prebuilt
> tools tarball or do we have a recipe for it.
> 
> This is probably enough to block the patch until we can find someone to
> look at fixing that :(

Ah, yeah, I see. It is a very useful testing library, but I could
take a look at rolling my own alternative. Unless there's a way
to make it acceptable for us with bitbake. Would creating a
recipe for it be enough? Or just skip the tests if mock isn't
available?

> Would it be possible to separate out the tests from the other changes?

Yes. I was planning to do that after our discussions on IRC, but
haven't gotten around to it yet. Will hopefully do that before
going on vacation on friday.


Thanks,
-- 
olofjn


  reply	other threads:[~2013-12-18 11:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 16:48 [RFC 0/5] Git fetcher changes for resolving tags Olof Johansson
2013-12-12 16:48 ` [RFC 1/5] fetch2/git: Improve handling of unresolved names verses branches Olof Johansson
2013-12-12 16:48 ` [RFC 2/5] bb.fetch2.git: reuse basecmd attribute Olof Johansson
2013-12-12 16:48 ` [RFC 3/5] bb.tests.fetch_git: initial set of tests for git fetcher Olof Johansson
2013-12-18 11:43   ` Richard Purdie
2013-12-18 11:51     ` Olof Johansson [this message]
2013-12-18 12:25       ` Richard Purdie
2013-12-12 16:48 ` [RFC 4/5] bb.fetch2.git: support resolving both tags and branches Olof Johansson
2013-12-12 16:48 ` [RFC 5/5] bb.fetch2.git: use the _gen_git_url() function Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131218115120.GM31548@axis.com \
    --to=olof.johansson@axis.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox