Re: [PATCH] cooker: check if target contains task

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Thu, Sep 15, 2016 at 09:03:24AM +0100, Richard Purdie wrote:
> On Fri, 2016-09-09 at 17:49 +0300, Ed Bartosh wrote:
> > Task name was incorrectly added to the targets that already
> > contained :task suffix and fired with BuildInit event. This
> > caused Toaster to create incorrect Target objects and show
> > them in UI.
> > 
> > [YOCTO #10221]
> > 
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > ---
> >  bitbake/lib/bb/cooker.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
> > index b7d7a7e..2952f9e 100644
> > --- a/bitbake/lib/bb/cooker.py
> > +++ b/bitbake/lib/bb/cooker.py
> > @@ -1421,7 +1421,8 @@ class BBCooker:
> >          if not task.startswith("do_"):
> >              task = "do_%s" % task
> >  
> > -        packages = ["%s:%s" % (target, task) for target in targets]
> > +        packages = [target if ':' in target else '%s:%s' (target,
> > task) for target in targets]
> > +
> >          bb.event.fire(bb.event.BuildInit(packages),
> > self.expanded_data)
> >  
> >          taskdata, runlist = self.buildTaskData(targets, task,
> > self.configuration.abort)
> 
> I put this into a build without looking too closely, the result was
> near enough everything failed with failures like:
> 
> http://autobuilder.yocto.io:8010/builders/buildtools/builds/37
> 

Sorry for the typo. I'll send an update in a minute.

--
Regards,
Ed