From: Mark Hatle <mark.hatle@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: [PATCH 0/7 v2] gitsm.py: submodule init and ssh url processing
Date: Tue, 15 Jan 2019 16:31:30 -0500 [thread overview]
Message-ID: <20190115213137.113956-1-mark.hatle@windriver.com> (raw)
v2:
A lot has been added and reported here. The original patch set had a
few minor tweaks made to them. However there was still a bug when
processing shallow submodules. This was corrected, along with a report
of download conflicts with multipel downloaders. (Fixed by inspection,
but since I can't reproduce it -- I have to believe it's resolved.)
Additionally, the last commit refactors the code and adds some additional
test cases to the upstream test respositories.
As with the v1 patch, there is a specific 'ssh' style URI conversion test
that happens only if the test case is manually activated by changing the
URL.
v1 info:
This patch set covers two different items. The first is work that started
before Christmas where someone noticed a repository that had a defined
gitmodule, but it was never initialized. The first patch deals with that
issue. (Thanks Raphael Lisicki for the fix approach...)
The second set works through the issues that Linus Ziegert, and
Krystian Garlinski have brought up on the list. This fix takes a
different approach then Linus's approach of adding a specific regex.
Instead we look for '://', if we find it -- its a URL, otherwise we
look for ':' -- finding that it must be 'ssh style', otherwise it
has to be a file URL. I think this simplifies the overall approach.
Finally a test case was developed. See:
http://git.yoctoproject.org/cgit/cgit.cgi/git-submodule-test/tree/.gitmodules?h=ssh-gitsm-tests
for the specific .gitmodules file that was tested. I would appreciate
it if the people experiencing problems could try out this code and
verify it works in their configurations.
RP - in the last patch, I wasn't sure how to switch which URL is used.
Either the original simplified testing or the more complex ssh based tests.
Any suggestions on a better way to handle this?
Mark Hatle (7):
gitsm.py: Fix when a submodule is defined, but not initialized
gitsm.py: Add support for alternative URL formats from submodule files
tests/fetch.py: Add alternative gitsm test case
gitsm.py: Optimize code and attempt to resolve locking issue
gitsm.py: revise unpack
gitsm.py: Rework the shallow fetcher and test case
gitsm.py: Refactor the functions and simplify the class
lib/bb/fetch2/gitsm.py | 257 ++++++++++++++++++++-----------------------------
lib/bb/tests/fetch.py | 24 ++++-
2 files changed, 125 insertions(+), 156 deletions(-)
--
1.8.3.1
next reply other threads:[~2019-01-15 21:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 21:31 Mark Hatle [this message]
2019-01-15 21:31 ` [PATCH 1/7] gitsm.py: Fix when a submodule is defined, but not initialized Mark Hatle
2019-01-18 15:07 ` Khem Raj
2019-01-18 18:07 ` Mark Hatle
2019-01-18 18:31 ` Khem Raj
2019-01-18 21:20 ` Mark Hatle
2019-01-18 23:06 ` Mark Hatle
2019-01-19 1:27 ` Khem Raj
2019-01-19 6:44 ` Khem Raj
2019-01-22 20:43 ` Mark Hatle
2019-01-23 3:36 ` Khem Raj
2019-01-15 21:31 ` [PATCH 2/7] gitsm.py: Add support for alternative URL formats from submodule files Mark Hatle
2019-01-15 21:31 ` [PATCH 3/7] tests/fetch.py: Add alternative gitsm test case Mark Hatle
2019-01-15 21:31 ` [PATCH 4/7] gitsm.py: Optimize code and attempt to resolve locking issue Mark Hatle
2019-01-15 21:31 ` [PATCH 5/7] gitsm.py: revise unpack Mark Hatle
2019-01-15 21:31 ` [PATCH 6/7] gitsm.py: Rework the shallow fetcher and test case Mark Hatle
2019-01-15 21:31 ` [PATCH 7/7] gitsm.py: Refactor the functions and simplify the class Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115213137.113956-1-mark.hatle@windriver.com \
--to=mark.hatle@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).