From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Minh Tiến Nguyễn" <zizuzacker@gmail.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/1] data_smart: fix operations lost when an override name contains a variable
Date: Sun, 26 Jul 2026 21:11:48 +0100 [thread overview]
Message-ID: <31e8eeb405240dac2aa53d750a5253e55e6eaabd.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAH9t78za_ncy=tnBv--DFqBvsxU-VCX8xGZaj_P-ef3PGvircA@mail.gmail.com>
On Sun, 2026-07-26 at 21:53 +0700, Minh Tiến Nguyễn wrote:
> > I think this is because expandKeys() calls renameVar and then
> > renameVar itself also calls renameVar() on the same element, which
> > breaks things. [...] then I think that resolve the issue?
>
> Yes, it does, and it is the better fix. Both keys are already in the
> todolist with their expanded names, so expandKeys() can rename them
> both. My patch only worked around the second rename with expand().
>
> I tested your diff on a fresh clone at c251833d2. It fixes the exact
> form from the bug report, :prepend and :remove, a conditional override
> with no operation keyword, several variables in one override name, and a
> variable in the key as well as in the override name, all of which fail
> on master. bb.tests.data passes, oe-core parses clean at 952 recipes
> with no new warnings, and both v1 test cases pass on your diff unchanged.
I have to wonder whether my reply is just being fed to AI? :/
The project's policy is that AI use isn't prohibited but it's use
should be made clear...
Cheers,
Richard
next prev parent reply other threads:[~2026-07-26 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 14:30 [PATCH 0/1] data_smart: fix key expansion in conditional overrides Nguyen Minh Tien
2026-07-25 14:30 ` [PATCH 1/1] data_smart: fix operations lost when an override name contains a variable Nguyen Minh Tien
2026-07-26 12:21 ` [bitbake-devel] " Richard Purdie
2026-07-26 14:53 ` Minh Tiến Nguyễn
2026-07-26 20:11 ` Richard Purdie [this message]
2026-08-04 21:12 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e8eeb405240dac2aa53d750a5253e55e6eaabd.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=zizuzacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox