Re: [PATCH] fetch2: raise an exception if user specifies protocol=git with http://

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Saturday 06 October 2012 15:38:45 Chris Larson wrote:
> On Sat, Oct 6, 2012 at 3:32 PM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
> > On Saturday 06 October 2012 15:27:42 Chris Larson wrote:
> >> On Wed, Oct 3, 2012 at 5:27 AM, Paul Eggleton
> >> 
> >> <paul.eggleton@linux.intel.com> wrote:
> >> > It is a common mistake to use http:// and protocol=git when attempting
> >> > to fetch from a git repository using the http protocol; if this is
> >> > detected then throw an error explaining that you need to use git://
> >> > with
> >> > protocol=http instead.
> >> > 
> >> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> >> 
> >> Perhaps this should check the protocol= value against the protocols
> >> supported by wget (ftp, http, https, etc), if the parameter is passed,
> >> rather than hardcoding the exceptions.
> > 
> > I don't think protocol= is currently used with the wget fetcher is it?
> 
> It isn't, but it also doesn't seem ideal to hardcode knowledge of the
> git fetcher in the wget one. Either way, I just wanted to make sure
> both options were considered.

I did consider checking for any use of protocol= and failing if any value is 
specified; perhaps we should still do that; for the purposes of helping people 
avoid a common pitfall however, it seems reasonable to me to check explicitly 
for protocol=git and I would still advocate leaving that check and message in 
even if we did add a general check on protocol.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre