Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 3/8] bb/ui/crumbs/tasklistmodel: don't include an item in its own depends
Date: Thu, 11 Aug 2011 15:57:26 -0700	[thread overview]
Message-ID: <396bbc220604c19ced4add30dd17f7f22d5e0022.1313103368.git.josh@linux.intel.com> (raw)
In-Reply-To: <cover.1313103368.git.josh@linux.intel.com>
In-Reply-To: <cover.1313103368.git.josh@linux.intel.com>

This causes the simple removal algorithm to perform needless circular logic

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/crumbs/tasklistmodel.py |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/lib/bb/ui/crumbs/tasklistmodel.py b/lib/bb/ui/crumbs/tasklistmodel.py
index aec80e2..7a463a6 100644
--- a/lib/bb/ui/crumbs/tasklistmodel.py
+++ b/lib/bb/ui/crumbs/tasklistmodel.py
@@ -237,6 +237,9 @@ class TaskListModel(gtk.ListStore):
 
             # uniquify the list of depends
             depends = self.squish(depends)
+            # remove circular dependencies
+            if name in depends:
+                depends.remove(name)
             deps = " ".join(depends)
 
             if name.count('task-') > 0:
-- 
1.7.6




  parent reply	other threads:[~2011-08-11 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 22:57 [PATCH 0/8] Various hob related patches Joshua Lock
2011-08-11 22:57 ` [PATCH 1/8] bb/ui/crumbs/tasklistmodel: fix some typos and add comments to mark() Joshua Lock
2011-08-11 22:57 ` [PATCH 2/8] bb/ui/crumbs/tasklistmodel: correctly uniquify dependency list Joshua Lock
2011-08-11 22:57 ` Joshua Lock [this message]
2011-08-11 22:57 ` [PATCH 4/8] bb/cache: rename confusing variable Joshua Lock
2011-08-11 22:57 ` [PATCH 5/8] bb/command|cooker: refactor the reparseFiles logic Joshua Lock
2011-08-11 22:57 ` [PATCH 6/8] bb/ui/crumbs/hobeventhandler: adapt to reset -> reparse change Joshua Lock
2011-08-11 22:57 ` [PATCH 7/8] bb/ui/crumbs/configurator: introduce writeConfFile method for all writes Joshua Lock
2011-08-11 22:57 ` [PATCH 8/8] lib/bb/ui/crumbs/hobprefs: fix erroneous save/reparse Joshua Lock
2011-08-12 16:48 ` [PATCH 0/8] Various hob related patches Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=396bbc220604c19ced4add30dd17f7f22d5e0022.1313103368.git.josh@linux.intel.com \
    --to=josh@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox