Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] bitbake/runqueue: Ensure finish_now() sets the runqueue state consistently
Date: Sun, 26 Feb 2012 17:41:34 +0800	[thread overview]
Message-ID: <4F49FE4E.4060903@windriver.com> (raw)
In-Reply-To: <1330185749.13788.44.camel@ted>


Hi Richard:

I have included this patch to the "V5 Disk space monitoring" as you suggested,
I have tested it, it worked well.

// Robert

On 02/26/2012 12:02 AM, Richard Purdie wrote:
> If we call finish_now(True), rq.state is not updated to match. This
> makes the behaviour of finish_now(False) and finish_now(True) consistent
> so both leave rq.state consistently.
>
> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
>
> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
> index c24841f..26a0f85 100644
> --- a/bitbake/lib/bb/runqueue.py
> +++ b/bitbake/lib/bb/runqueue.py
> @@ -1060,6 +1060,13 @@ class RunQueueExecute:
>           for pipe in self.build_pipes:
>               self.build_pipes[pipe].read()
>
> +        if len(self.failed_fnids) != 0:
> +            self.rq.state = runQueueFailed
> +            return
> +
> +        self.rq.state = runQueueComplete
> +        return
> +
>       def finish(self):
>           self.rq.state = runQueueCleanUp
>
>
>
>
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel
>



      reply	other threads:[~2012-02-26  9:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25 16:02 [PATCH] bitbake/runqueue: Ensure finish_now() sets the runqueue state consistently Richard Purdie
2012-02-26  9:41 ` Robert Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F49FE4E.4060903@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox