From: Joshua Lock <josh@linux.intel.com>
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: bitbake-devel@lists.openembedded.org, Giulia Piu <giulia@closertag.com>
Subject: Re: [PATCH 5/6] ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use Close.
Date: Tue, 20 Mar 2012 10:29:25 -0700 [thread overview]
Message-ID: <4F68BE75.7080404@linux.intel.com> (raw)
In-Reply-To: <1332223450.1848.19.camel@dongxiao-osel>
On 19/03/12 23:04, Xu, Dongxiao wrote:
> On Mon, 2012-03-19 at 17:18 -0700, Joshua Lock wrote:
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>> ---
>> lib/bb/ui/crumbs/builder.py | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/bb/ui/crumbs/builder.py b/lib/bb/ui/crumbs/builder.py
>> index 1d255ac..9e85e72 100755
>> --- a/lib/bb/ui/crumbs/builder.py
>> +++ b/lib/bb/ui/crumbs/builder.py
>> @@ -668,8 +668,7 @@ class Builder(gtk.Window):
>> flags = gtk.DIALOG_MODAL
>> | gtk.DIALOG_DESTROY_WITH_PARENT
>> | gtk.DIALOG_NO_SEPARATOR,
>> - buttons = (gtk.STOCK_CANCEL, gtk.RESPONSE_NO,
>> - gtk.STOCK_OK, gtk.RESPONSE_YES))
>> + buttons = (gtk.STOCK_CLOSE, gtk.RESPONSE_YES))
>
> If users did some trial operations, for example deleted some layers, is
> it better that we provide a "cancel" button for users to ignore their
> changes?
>
> Need comments from Belen and Giulia.
Fair point, I'll wait for input from the design team for this one.
Cheers,
Joshua
--
Joshua '贾詡' Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-20 17:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 0:18 [PATCH 0/6] Hob tweaks Joshua Lock
2012-03-20 0:18 ` [PATCH 1/6] ui/crumbs/hig: use close rather than OK for dismis button Joshua Lock
2012-03-20 5:33 ` Xu, Dongxiao
2012-03-20 0:18 ` [PATCH 2/6] ui/crumbs: remove unused return value from append_toolbar_button Joshua Lock
2012-03-20 5:30 ` Xu, Dongxiao
2012-03-20 0:18 ` [PATCH 3/6] ui/crumbs/hobpage: no need to force a Toolbar button type Joshua Lock
2012-03-20 5:49 ` Xu, Dongxiao
2012-03-20 0:18 ` [PATCH 4/6] ui/crumbs/persistenttooltip: try to reflect WM close button position Joshua Lock
2012-03-20 5:59 ` Xu, Dongxiao
2012-03-20 0:18 ` [PATCH 5/6] ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use Close Joshua Lock
2012-03-20 6:04 ` Xu, Dongxiao
2012-03-20 17:29 ` Joshua Lock [this message]
2012-03-20 0:18 ` [PATCH 6/6] ui/crumbs/hig: make the layer selection dialogue more closely match design Joshua Lock
2012-03-20 6:08 ` Xu, Dongxiao
2012-03-20 15:25 ` Joshua Lock
2012-03-20 14:34 ` [PATCH 0/6] Hob tweaks Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F68BE75.7080404@linux.intel.com \
--to=josh@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=dongxiao.xu@intel.com \
--cc=giulia@closertag.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox