Re: [PATCH 0/6] V2 hob2: some tweak and add a standalone deploy image tool

[Kang Kai <Kai.Kang@windriver.com>]

On 2012年06月08日 23:05, Darren Hart wrote:
>
> On 06/08/2012 04:14 AM, Richard Purdie wrote:
>> On Wed, 2012-06-06 at 17:52 +0800, Kang Kai wrote:
>>> Hi Darren,
>>>
>>> Thanks for your detailed reivew.
>>>
>>> V2 update:
>>> 1. break up the commit about hig.py
>>> 2. some text tweak
>>> 3. remove the gtk version check
>>> 4. rename the standalone tool
>>>
>>> V1:
>>> These 2 patches try to add a standalone deploy image tool using current codes.
>>> It should be launched by run the absolute path to bitbake/bin/bitbake-deployimage,
>>> I'll add a shell script to wrap it under script directory.
>>>
>>> Regards,
>>> Kai
>>> The following changes since commit de4cdfd6bc1280ac7ac0559b87734d26294ef773:
>>>
>>>    documentation/kernel-manual/kernel-how-to.xml: Updated to kernel 3.4 (2012-05-31 21:16:55 +0100)
>>>
>>> are available in the git repository at:
>>>    git://git.pokylinux.org/poky-contrib kangkai/distro
>>>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro
>>>
>>> Kang Kai (6):
>>>    ui/crumbs/utils.py: import module bb
>>>    ui/crumbs/hig.py: fix run time error
>>>    ui/crumbs/hig.py: remove extra spaces
>>>    ui/crumbs/hig.py: check deploy process return value
>>>    hob2: update DeployImageDialog for seperated tool
>>>    hob2: create a standalone deploy image tool
>> Merged to master, thanks.

Hi Darren,

> This happened a bit more quickly than I could get to reviewing V2 for
> the inclusion of my feedback.
>
> I've gone ahead and reviewed the patchset again. The breakout looks spot
> on, thanks Kang. There are various other minor issues, mostly with the
> strings. Please have a look and consider submitting a follow-on patch
> series.

Sorry for late response because I had sick leave for last 2 days.
I will send patch to amend the problems according to your comments.

Thanks,
Kai


> Thanks,
>