Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] hob: report event handler failures
Date: Wed, 19 Sep 2012 07:02:32 -0500	[thread overview]
Message-ID: <5059B458.3070403@windriver.com> (raw)
In-Reply-To: <1348050342-5402-1-git-send-email-paul.eggleton@linux.intel.com>

On 09/19/2012 05:25 AM, Paul Eggleton wrote:
> If an event handler failed we were not recieving an error message -
> parsing just "froze" at 99%. This is because we were expecting a
> CommandFailure event and this never happened in the case of
> RequestPackageInfo which is where the failure was occurring.
>
> This also required tweaking the error formatting slightly, taking the
> return value of the format function rather than the message property
> since the latter only seems to contain the first line without the
> traceback in the case of event handler failure. Other error cases were
> tested and their message formatting is unaffected by this change.
>

This looks good Paul.  

Thanks for fixing this up so we can get the reporting. :-)

Cheers,
Jason.



  reply	other threads:[~2012-09-19 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 10:25 [PATCH] hob: report event handler failures Paul Eggleton
2012-09-19 12:02 ` Jason Wessel [this message]
2012-09-20 10:49 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5059B458.3070403@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox