Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: Alex Franco <alejandro.franco@linux.intel.com>,
	<bitbake-devel@lists.openembedded.org>
Cc: david.nystrom@enea.com, clarson@kergoth.com
Subject: Re: [PATCH] Allow bitbake commands starting with do_ v2
Date: Mon, 31 Aug 2015 15:16:46 -0500	[thread overview]
Message-ID: <55E4B62E.7070400@windriver.com> (raw)
In-Reply-To: <1441051232-30028-1-git-send-email-alejandro.franco@linux.intel.com>

On 8/31/15 3:00 PM, Alex Franco wrote:
> The output of "bitbake, -c listtasks pkg" lists tasks with their real names
> (starting with "do_"), but then "bitbake -c do_task" fails, as "do_" always
> gets unconditionally prepended to task names. This patch handles this error
> by always removing "do_" from the beginning of task names when the runqueue
> is being constructed.
> 
> [YOCTO #7818]
> 
> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
> ---
>  bitbake/lib/bb/runqueue.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
> index 0f99e5a..834992f 100644
> --- a/bitbake/lib/bb/runqueue.py
> +++ b/bitbake/lib/bb/runqueue.py
> @@ -634,6 +634,10 @@ class RunQueueData:
>  
>              fnid = taskData.build_targets[targetid][0]
>              fn = taskData.fn_index[fnid]
> +
> +            if target[1].startswith("do_"):
> +                target[1] = target[1].replace("do_", "", 1)
> +

not sure if it's faster and/or more obvious...

target[1] = target[1][3:]

(since we know the first three characters are 'do_' since we did a 'startswith'...)

--Mark

>              self.target_pairs.append((fn, target[1]))
>  
>              if fnid in taskData.failed_fnids:
> 



  reply	other threads:[~2015-08-31 20:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 20:00 [PATCH] Allow bitbake commands starting with do_ v2 Alex Franco
2015-08-31 20:16 ` Mark Hatle [this message]
2015-08-31 20:18 ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E4B62E.7070400@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=alejandro.franco@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=clarson@kergoth.com \
    --cc=david.nystrom@enea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox