From: Robert Yang <liezhi.yang@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH 1/1] fetch2/git.py: remove .indirectiondir workaround
Date: Wed, 6 Apr 2016 09:33:24 +0800 [thread overview]
Message-ID: <57046764.2010800@windriver.com> (raw)
In-Reply-To: <1459867622.7348.168.camel@linuxfoundation.org>
On 04/05/2016 10:47 PM, Richard Purdie wrote:
> On Tue, 2016-04-05 at 14:36 +0100, Richard Purdie wrote:
>> On Tue, 2016-04-05 at 03:35 -0700, Robert Yang wrote:
>>> It was used for workaround git 1.7.9.2 which was released in 2012
>>> which
>>> should not be existed on nowadays host, so remove it to avoid
>>> confusions.
>>
>> I like the idea of this however:
>>
>> $ cat classes/sanity.bbclass | grep 7.8
>> # We use git parameters and functionality only found in 1.7.8 or
>> later
>> if LooseVersion(version) < LooseVersion("1.7.8"):
>> return "Your version of git is older than 1.7.8 and has bugs
>> which will break builds. Please install a newer version of git.\n"
>>
>> so we have a minimum version of 1.7.8 defined right now...
>>
>> I'd be ok merging this if we increase the minimum version
>> requirement.
>
> There is also another issue pending on increased git version so I've
> just sent a patch for this, which would then unblock this one.
Thank you very much.
// Robert
>
> Cheers,
>
> Richard
>
prev parent reply other threads:[~2016-04-06 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 10:35 [PATCH 0/1] fetch2/git.py: remove .indirectiondir workaround Robert Yang
2016-04-05 10:35 ` [PATCH 1/1] " Robert Yang
2016-04-05 13:36 ` Richard Purdie
2016-04-05 14:47 ` Richard Purdie
2016-04-06 1:33 ` Robert Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57046764.2010800@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox