Re: [bitbake-devel] [PATCH v2 3/4] bitbake-setup: print colored diffs

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi,

On Thu Feb 19, 2026 at 10:36 AM CET, Alexander Kanavin wrote:
> On Wed, 18 Feb 2026 at 16:27, Antonin Godard via
> lists.openembedded.org
> <antonin.godard=bootlin.com@lists.openembedded.org> wrote:
>
>> Oops, this slipped through, but shouldn't be changed at all since it is removed
>> in the next commit. I will resend the series.
>
> Also the function is *way* over-engineered. I only wanted to avoid
> repeating the color logic, so perhaps just this bit could be
> abstracted and used in all three locations?
>
> def get_color_param():
>     return "always" if BBSETUP_COLOR else "never"

Not sure I follow.

def color_enabled() -> bool:
    return logger.handlers[0].formatter.color_enabled

IMO this is better than the previous version which did:

global BBSETUP_COLOR
if args.color == 'always' or (args.color == 'auto' and sys.stdout.isatty() and os.environ.get('NO_COLOR', '') == ''):
    BBSETUP_COLOR = True

That logic is already present in the logger object, in msg.py, when creating the
logger:

if color == 'always' or (color == 'auto' and output.isatty() and os.environ.get('NO_COLOR', '') == ''):
    format.enable_color()

The proposal here was to get rid of BBSETUP_COLOR entirely and avoid
duplication. Not sure how this is *way* over-engineered, I'd rather see it as a
simplification

Antonin