Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <mischief@offblast.org>, <bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH] fetch2: accept sha256 revisions
Date: Thu, 18 Jun 2026 19:06:52 +0200	[thread overview]
Message-ID: <DJCC8O98GW1V.95VRNYO90WVL@bootlin.com> (raw)
In-Reply-To: <20260618100903.231245-2-mischief@offblast.org>

On Thu Jun 18, 2026 at 12:09 PM CEST, Nick Owens via lists.openembedded.org wrote:
> regexes in fetch2's git support currently don't allow for fetching git
> repos with the sha256 object format.
>
> to allow fetching sha256 git repos, adjust the regular expression and
> fix all of the references.
>
> tested on my gitea server with a sha256 repo
>
> fixes https://bugzilla.yoctoproject.org/show_bug.cgi?id=16322
>
> Signed-off-by: Nick Owens <mischief@offblast.org>
> ---

Hi Nick,

Thanks for your patch.

It looks like we still have some use of sha1_re in bitbake-setup, and so
have a failing bitbake selftest:

ERROR: test_setup (bb.tests.setup.BitbakeSetupTest.test_setup)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/lib/bb/tests/setup.py", line 389, in test_setup
    self.check_setupdir_files(setuppath, test_file_content)
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/lib/bb/tests/setup.py", line 296, in check_setupdir_files
    self.config_is_unchanged(setuppath)
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/lib/bb/tests/setup.py", line 237, in config_is_unchanged
    out = self.runbbsetup(["status"])
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/lib/bb/tests/setup.py", line 106, in runbbsetup
    return bb.process.run([bbsetup, '--global-settings', os.path.join(self.tempdir, 'global-config')] + cmd, env=env, cwd=self.tempdir)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/lib/bb/process.py", line 189, in run
    raise ExecutionError(cmd, pipe.returncode, stdout, stderr)
bb.process.ExecutionError: Execution of '/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/bin/bitbake-setup --global-settings /tmp/bitbake-fetch-irglhhir/global-config status' failed with exit code 1:
NOTE: Loading settings from /tmp/bitbake-fetch-irglhhir/global-config
NOTE: Loading settings from /tmp/bitbake-fetch-irglhhir/bitbake-builds/settings.conf
NOTE: Bitbake-setup is using /tmp/bitbake-fetch-irglhhir/bitbake-builds as top directory.
NOTE: Looking up config test-config-1 in configuration registry
NOTE: Fetching configuration registry
    git:///tmp/bitbake-fetch-irglhhir/bitbake-setup-configurations;protocol=file;branch=master;rev=master
into
    /tmp/bitbake-fetch-irglhhir/bitbake-builds/.bitbake-setup-cache/configurations
ERROR: cannot import name 'sha1_re' from 'bb.fetch2.git' (/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/bitbake/lib/bb/fetch2/git.py)

https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/4067
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/3917

Can you fix this?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



      reply	other threads:[~2026-06-18 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 10:09 [PATCH] fetch2: accept sha256 revisions Nick Owens
2026-06-18 17:06 ` Mathieu Dubois-Briand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJCC8O98GW1V.95VRNYO90WVL@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=mischief@offblast.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox