Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Martin Jansa <martin.jansa@gmail.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH 2/7] data_smart: Micro optimise _remove handling
Date: Fri, 19 Oct 2018 10:55:32 +0100	[thread overview]
Message-ID: <bb42f42df90ade4c9d601b63162cfccfc92bbf14.camel@linuxfoundation.org> (raw)
In-Reply-To: <CA+chaQdmU3WeTOy6UT3TGm97ucX98tXA=DOD5uTgY=tsB=4Y8A@mail.gmail.com>

On Fri, 2018-10-19 at 10:57 +0200, Martin Jansa wrote:
> This one and "data_smart: Fix expand_cache and _remove operator
> interaction issues" are slightly changing the behavior, not sure if
> this change was intended.

I think this is a bug, thanks for reporting. I was able to reprocduce
with OE-Core and a bbappend containing the line you mentioned. The way
RDEPENDS are handled in insane.bbclass is a little unique and I was
able to reduce it to a test case:

    def test_remove_with_override(self):
        self.d.setVar("TEST_bar", "testvalue2")
        self.d.setVar("TEST_some_val", "testvalue3 testvalue5")
        self.d.setVar("TEST_some_val_remove", "testvalue3")
        self.d.setVar("TEST_foo", "testvalue4")
        self.d.setVar("OVERRIDES", "foo:bar:some_val")
        self.assertEqual(self.d.getVar("TEST"), " testvalue5")

and this gives a good pointer to where/how the code is breaking. I'll
try and figure out how to fix it (and add a test case for it!).

Cheers,

Richard



  reply	other threads:[~2018-10-19  9:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18  9:22 [PATCH 1/7] fetch2: Avoid incorrect getVarFlag call Richard Purdie
2018-10-18  9:22 ` [PATCH 2/7] data_smart: Micro optimise _remove handling Richard Purdie
2018-10-19  8:57   ` Martin Jansa
2018-10-19  9:55     ` richard.purdie [this message]
2018-10-18  9:22 ` [PATCH 3/7] data_smart: Fix expand_cache and _remove operator interaction issues Richard Purdie
2018-10-18  9:22 ` [PATCH 4/7] data/data_smart: Allow getVarFlag to return the variable parser object Richard Purdie
2018-10-18  9:22 ` [PATCH 5/7] bitbake: data: Ensure task checksums account for remove data Richard Purdie
2018-10-18  9:22 ` [PATCH 6/7] data/siggen: Extract task hash generation code into a function Richard Purdie
2018-10-18  9:22 ` [PATCH 7/7] test/data: Add new tests for task checksum changing/not changing Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb42f42df90ade4c9d601b63162cfccfc92bbf14.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=martin.jansa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox