Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 0/2] Fixes for the fetcher
Date: Thu, 20 Jun 2013 11:35:47 +0200	[thread overview]
Message-ID: <cover.1371720878.git.pkj@axis.com> (raw)

We need the SFTP fetcher for one of our recipes. As it turned out when I
wrote the recipe, the fetcher failed to retrieve the sources because it
wanted me to specify checksums for them. However, the checksums _were_
specified in the recipe.

After examining the code for the fetcher, it turned out that the list of
fetchers that expect a checksum is hardcoded in the constructor of
FetchData in lib/bb/fetch2/__init__.py, whereas verify_checksum() uses
ud.method.supports_checksum() and ud.method.recommends_checksum() to
determine if a checksum is needed. Needless to say, this of course
failed as the hardcoded values did not match reality.

This patch updates the list of hardcoded fetchers to include SFTP, but I
consider it more of a bandage, and someone with better Python skills
than mine should rewrite the constructor to not use a hardcoded list.

//Peter

The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:

  package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/fetch_sftp
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/fetch_sftp

Peter Kjellerstedt (2):
  Allow checksums to be used for files retrieved using SFTP
  Correct a typo

 bitbake/lib/bb/fetch2/__init__.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
1.8.2.1



             reply	other threads:[~2013-06-20  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  9:35 Peter Kjellerstedt [this message]
2013-06-20  9:35 ` [PATCH 1/2] Allow checksums to be used for files retrieved using SFTP Peter Kjellerstedt
2013-06-20  9:35 ` [PATCH 2/2] Correct a typo Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1371720878.git.pkj@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox