From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: "richard.purdie@linuxfoundation.org"
<richard.purdie@linuxfoundation.org>,
"bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH 2/3] data_smart: Allow numeric characters in overrides
Date: Wed, 19 Dec 2018 16:12:34 +0000 [thread overview]
Message-ID: <e1b2cb22e101463f8afa8a4fe084f869@XBOX04.axis.com> (raw)
In-Reply-To: <ab481f529628568941f4790a2cad883ac00b6384.camel@linuxfoundation.org>
> -----Original Message-----
> From: richard.purdie@linuxfoundation.org
> <richard.purdie@linuxfoundation.org>
> Sent: den 19 december 2018 12:42
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; bitbake-
> devel@lists.openembedded.org
> Subject: Re: [bitbake-devel] [PATCH 2/3] data_smart: Allow numeric
> characters in overrides
>
> On Wed, 2018-12-19 at 10:55 +0000, Peter Kjellerstedt wrote:
> > I don't understand the commit message either. It says that there are
> > problems with x86-64 because it contains digits, but x86 (which the
> > commit message says works) contains digits too, so that cannot
> > really
> > be the case. If it is actually the dash in x86-64 that is supposedly
> > a cause of problems, then islower() ignores both digits and non-
> > alpha
> > characters like the dash so that cannot really be a reason to change
> > the code either. All in all I'm confused by this commit and what it
> > is trying to solve...
>
> Consider this output from python:
>
> >>> "64".islower()
> False
> >>> "x64".islower()
> True
> >>> "x64A".islower()
> False
> >>>
>
> The problem is that "64".islower() returns False when we need True
> (overrides get split by '_' so x86_64 turns into "x86" and "64" in the
> code in question).
>
> Cheers,
>
> Richard
Ok, that makes more sense, except for one thing: where/when is _x86_64
used as override(s)? The only related overrides I can find in OE-Core
all use _x86-64, which matches ${TRANSLATED_TARGET_ARCH} for, e.g.,
qemux86-64.
//Peter
next prev parent reply other threads:[~2018-12-19 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 14:02 [PATCH 1/3] data_smart: Add missing regexp markup Richard Purdie
2018-12-14 14:02 ` [PATCH 2/3] data_smart: Allow numeric characters in overrides Richard Purdie
2018-12-18 21:05 ` Peter Kjellerstedt
2018-12-18 21:16 ` richard.purdie
2018-12-19 10:55 ` Peter Kjellerstedt
2018-12-19 11:42 ` richard.purdie
2018-12-19 16:12 ` Peter Kjellerstedt [this message]
2018-12-19 19:59 ` richard.purdie
2018-12-14 14:02 ` [PATCH 3/3] utils: Add aarch64 support to ioprio_set Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1b2cb22e101463f8afa8a4fe084f869@XBOX04.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox