From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 645A7C7619A for ; Wed, 5 Apr 2023 19:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjDETQQ (ORCPT ); Wed, 5 Apr 2023 15:16:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbjDETQP (ORCPT ); Wed, 5 Apr 2023 15:16:15 -0400 Received: from out-2.mta0.migadu.com (out-2.mta0.migadu.com [IPv6:2001:41d0:1004:224b::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20EF7527F for ; Wed, 5 Apr 2023 12:16:13 -0700 (PDT) Message-ID: <00f36cce-f186-2d39-ae5c-67da3f43129b@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1680722171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZceX/Eoe69nalU7lP+K5hhfjIcsy8iiHRRMCLOztTvk=; b=FfuWSxl5fdFOTBkCkYdDf1WxI4Aiv4Kx2kNbPcnmtgoc8BSSJWPCFMDxITpMHcWxymxfvT ItCBnbX23xHZ050kkYq5srCgfcDibatXRKd7vsBlUGCevqURrg9p4Juia/o4jeS+CR/Hyw 0VIOQQm7RJlO7UrjBLeYWRaTqIOJi9A= Date: Wed, 5 Apr 2023 12:16:07 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next 0/2] selftests: xsk: Add test case for packets at end of UMEM Content-Language: en-US To: Kal Conley , Magnus Karlsson Cc: bpf@vger.kernel.org References: <20230403145047.33065-1-kal.conley@dectris.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20230403145047.33065-1-kal.conley@dectris.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 4/3/23 7:50 AM, Kal Conley wrote: > This patchset fixes a minor bug in xskxceiver.c then adds a test case > for valid packets at the end of the UMEM. I tried test_xsk.sh. The changed subtest runs ok, so applied. I got failures from test_xsk.sh (even before this set) though. Are these expected or something missing in the environment like kconfig? ./test_xsk.sh PREREQUISITES: [ PASS ] 1..42 ok 1 PASS: SKB RUN_TO_COMPLETION ok 2 PASS: SKB RUN_TO_COMPLETION_2K_FRAME_SIZE ok 3 PASS: SKB RUN_TO_COMPLETION_SINGLE_PKT ok 4 PASS: SKB POLL_RX ok 5 PASS: SKB POLL_TX ok 6 PASS: SKB POLL_RXQ_EMPTY ok 7 PASS: SKB POLL_TXQ_FULL ok 8 # SKIP No 2M huge pages present. ok 9 PASS: SKB ALIGNED_INV_DESC ok 10 PASS: SKB ALIGNED_INV_DESC_2K_FRAME_SIZE ok 11 # SKIP No 2M huge pages present. ok 12 PASS: SKB UMEM_HEADROOM ok 13 PASS: SKB TEARDOWN ok 14 PASS: SKB BIDIRECTIONAL not ok 15 FAIL: SKB STAT_RX_DROPPED ok 16 PASS: SKB STAT_TX_INVALID ok 17 PASS: SKB STAT_RX_FULL ok 18 PASS: SKB STAT_RX_FILL_EMPTY ok 19 PASS: SKB BPF_RES ok 20 PASS: SKB XDP_DROP_HALF ok 21 PASS: SKB XDP_METADATA_COUNT ok 22 PASS: DRV RUN_TO_COMPLETION ok 23 PASS: DRV RUN_TO_COMPLETION_2K_FRAME_SIZE ok 24 PASS: DRV RUN_TO_COMPLETION_SINGLE_PKT ok 25 PASS: DRV POLL_RX ok 26 PASS: DRV POLL_TX ok 27 PASS: DRV POLL_RXQ_EMPTY ok 28 PASS: DRV POLL_TXQ_FULL ok 29 # SKIP No 2M huge pages present. ok 30 PASS: DRV ALIGNED_INV_DESC ok 31 PASS: DRV ALIGNED_INV_DESC_2K_FRAME_SIZE ok 32 # SKIP No 2M huge pages present. ok 33 PASS: DRV UMEM_HEADROOM ok 34 PASS: DRV TEARDOWN ok 35 PASS: DRV BIDIRECTIONAL not ok 36 FAIL: DRV STAT_RX_DROPPED ok 37 PASS: DRV STAT_TX_INVALID ok 38 PASS: DRV STAT_RX_FULL ok 39 PASS: DRV STAT_RX_FILL_EMPTY ok 40 PASS: DRV BPF_RES ok 41 PASS: DRV XDP_DROP_HALF ok 42 PASS: DRV XDP_METADATA_COUNT # Totals: pass:36 fail:2 xfail:0 xpass:0 skip:4 error:0 XSK_SELFTESTS_ve4206_SOFTIRQ: [ FAIL ] 1..42 ok 1 PASS: SKB BUSY-POLL RUN_TO_COMPLETION ok 2 PASS: SKB BUSY-POLL RUN_TO_COMPLETION_2K_FRAME_SIZE ok 3 PASS: SKB BUSY-POLL RUN_TO_COMPLETION_SINGLE_PKT ok 4 PASS: SKB BUSY-POLL POLL_RX ok 5 PASS: SKB BUSY-POLL POLL_TX ok 6 PASS: SKB BUSY-POLL POLL_RXQ_EMPTY ok 7 PASS: SKB BUSY-POLL POLL_TXQ_FULL ok 8 # SKIP No 2M huge pages present. ok 9 PASS: SKB BUSY-POLL ALIGNED_INV_DESC ok 10 PASS: SKB BUSY-POLL ALIGNED_INV_DESC_2K_FRAME_SIZE ok 11 # SKIP No 2M huge pages present. ok 12 PASS: SKB BUSY-POLL UMEM_HEADROOM ok 13 PASS: SKB BUSY-POLL TEARDOWN ok 14 PASS: SKB BUSY-POLL BIDIRECTIONAL not ok 15 FAIL: SKB BUSY-POLL STAT_RX_DROPPED ok 16 PASS: SKB BUSY-POLL STAT_TX_INVALID ok 17 PASS: SKB BUSY-POLL STAT_RX_FULL ok 18 PASS: SKB BUSY-POLL STAT_RX_FILL_EMPTY ok 19 PASS: SKB BUSY-POLL BPF_RES ok 20 PASS: SKB BUSY-POLL XDP_DROP_HALF ok 21 PASS: SKB BUSY-POLL XDP_METADATA_COUNT ok 22 PASS: DRV BUSY-POLL RUN_TO_COMPLETION ok 23 PASS: DRV BUSY-POLL RUN_TO_COMPLETION_2K_FRAME_SIZE ok 24 PASS: DRV BUSY-POLL RUN_TO_COMPLETION_SINGLE_PKT ok 25 PASS: DRV BUSY-POLL POLL_RX # [is_pkt_valid] expected seqnum [671], got seqnum [673] not ok 26 FAIL: DRV BUSY-POLL POLL_TX ok 27 PASS: DRV BUSY-POLL POLL_RXQ_EMPTY ok 28 PASS: DRV BUSY-POLL POLL_TXQ_FULL ok 29 # SKIP No 2M huge pages present. not ok 30 [xskxceiver.c:xsk_configure_socket:1230]: ERROR: 16/"Device or resource busy" # Planned tests != run tests (42 != 30) # Totals: pass:24 fail:3 xfail:0 xpass:0 skip:3 error:0 Summary: XSK_SELFTESTS_ve4206_SOFTIRQ: [ FAIL ]