From: Tao Chen <chen.dylane@linux.dev>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, song@kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
eddyz87@gmail.com, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v8 1/3] perf: Add rctx in perf_callchain_entry
Date: Thu, 29 Jan 2026 00:52:52 +0800 [thread overview]
Message-ID: <00fd7c67-dffa-4647-8370-59a195a41deb@linux.dev> (raw)
In-Reply-To: <20260128085945.GF3372621@noisy.programming.kicks-ass.net>
在 2026/1/28 16:59, Peter Zijlstra 写道:
> On Mon, Jan 26, 2026 at 03:43:29PM +0800, Tao Chen wrote:
>> Record rctx inside the perf_callchain_entry itself, when callers of
>> get_callchain_entry no longer care about the assignment of rctx, and
>> will be used in the next patch.
>
> Sorry, what?
>
> The recursion context is very much about the caller, and very much not
> about the data. This just doesn't make sense.
Well, Andrii, it seems we have to go back to the original way.
--
Best Regards
Tao Chen
next prev parent reply other threads:[~2026-01-28 16:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 7:43 [PATCH bpf-next v8 0/3] Pass external callchain entry to get_perf_callchain Tao Chen
2026-01-26 7:43 ` [PATCH bpf-next v8 1/3] perf: Add rctx in perf_callchain_entry Tao Chen
2026-01-26 8:03 ` bot+bpf-ci
2026-01-26 8:51 ` Tao Chen
2026-01-27 21:01 ` Andrii Nakryiko
2026-01-28 2:41 ` Tao Chen
2026-01-28 8:59 ` Peter Zijlstra
2026-01-28 16:52 ` Tao Chen [this message]
2026-01-28 18:59 ` Andrii Nakryiko
2026-01-29 3:03 ` Tao Chen
2026-01-26 7:43 ` [PATCH bpf-next v8 2/3] perf: Refactor get_perf_callchain Tao Chen
2026-01-27 21:07 ` Andrii Nakryiko
2026-01-28 2:42 ` Tao Chen
2026-01-28 9:10 ` Peter Zijlstra
2026-01-28 16:49 ` Tao Chen
2026-01-28 19:12 ` Andrii Nakryiko
2026-01-30 11:31 ` Peter Zijlstra
2026-01-30 20:04 ` Andrii Nakryiko
2026-02-02 19:59 ` Peter Zijlstra
2026-02-04 0:24 ` Andrii Nakryiko
2026-02-04 1:08 ` Andrii Nakryiko
2026-02-05 6:16 ` Tao Chen
2026-02-05 17:34 ` Andrii Nakryiko
2026-02-06 9:20 ` Tao Chen
2026-01-26 7:43 ` [PATCH bpf-next v8 3/3] bpf: Hold ther perf callchain entry until used completely Tao Chen
2026-01-27 21:35 ` Andrii Nakryiko
2026-01-28 4:21 ` Tao Chen
2026-01-28 19:13 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fd7c67-dffa-4647-8370-59a195a41deb@linux.dev \
--to=chen.dylane@linux.dev \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox