From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3092C1AC for ; Thu, 4 Jan 2024 19:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="RfML0zpv" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d4ab4e65aeso12296565ad.0 for ; Thu, 04 Jan 2024 11:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1704395532; x=1705000332; darn=vger.kernel.org; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=wiuAbn1hA+wD2zanBuCoA6Xdp/ZRkyF/eu8Vv75E5eo=; b=RfML0zpvfX0WvcbBFM4tkJjHu4JlaLSfa0/ZBQmuv3iCsyUg6QLLxpc7U8aJfPTflr QkCygdaeBzjptmGH8YG6y/v1xtyTpP17NFfjpNa4JZowCjVSwQCR6+HC9SQs7V8EBVvq cSjD/LHVp1fa51531fbhsGW86uqDufzsbjjyxZ+CYBYQYz0CUZTPs1MmDz2Ns0u7i79d jNNE3koYpzR47UM9IuzKG9r95tM0WaypdoxLAhB391Hdhm3B6kL0sFedcBs4NIP+2zMP WHCAPUlwmQiFyoYSMXzd+CSfrSRGrp/fH9SmhB14jR8PAizi7jI88Uan8fgLPwd0SUX+ U3Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704395532; x=1705000332; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiuAbn1hA+wD2zanBuCoA6Xdp/ZRkyF/eu8Vv75E5eo=; b=lo66PnOUBMz9ainT7xlxpVyAooH7RhB4tR3DT2s/tV34VHmvbiPcyDPwULa+dkHKGy AaiZ2Dg8ttMZFmlE9JtLW2MWAiIeKF3k1+KZX/FX1ekbH3bl7Z72OyHAWSQIvir3plw5 7R4XEhwRxmluCYRBB+UUXu1P81QlZt0z9CTP7UsyurAo8ITxncjrxOiLh60KQgF9+9NA onSi7PlYvrXF7EAJy8biNhneeYJUQjkCU/cLieyjfw5A5Zi1i7Y8REnm7qi7KVwzIDIF Iusre8EOcsobsIexu88Wq28GQBY61AEnk2XSd3Un+gfa/bCV/OClcmVcCNsYVstQp6p3 auow== X-Gm-Message-State: AOJu0YxKvz3zTYLRj28FwQCLFd5CfKxTSZAxpta6i950UDenOK1VeYyl qLTqkOKLWjT+/+OVIQTLuN4= X-Google-Smtp-Source: AGHT+IF8NBDEzEGYQcF27Qh4/HMfq2Q29GAe84qQeg2jGA8hMXmsXodkyDwrxrzH/bMNHmGnbODQ7A== X-Received: by 2002:a17:903:484:b0:1d4:e575:520a with SMTP id jj4-20020a170903048400b001d4e575520amr165714plb.46.1704395531858; Thu, 04 Jan 2024 11:12:11 -0800 (PST) Received: from ArmidaleLaptop (c-67-170-74-237.hsd1.wa.comcast.net. [67.170.74.237]) by smtp.gmail.com with ESMTPSA id h9-20020a170902f7c900b001d4752f5403sm17021666plw.206.2024.01.04.11.12.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jan 2024 11:12:11 -0800 (PST) From: dthaler1968@googlemail.com X-Google-Original-From: To: "'Aoyang Fang \(SSE, 222010547\)'" , , Cc: References: <3A7D0A57-02EF-4ACB-A599-1029CFCA7E74@link.cuhk.edu.cn> In-Reply-To: <3A7D0A57-02EF-4ACB-A599-1029CFCA7E74@link.cuhk.edu.cn> Subject: RE: [PATCH] update the consistency issue in documentation Date: Thu, 4 Jan 2024 11:12:09 -0800 Message-ID: <015701da3f41$eaab4d10$c001e730$@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQJcMuQj7ImLqPZXOVe7T7DiaRKhU6/GHKMQ > -----Original Message----- > From: Aoyang Fang (SSE, 222010547) > Sent: Wednesday, January 3, 2024 7:13 PM > To: bpf@vger.kernel.org; bpf@ietf.org > Cc: void@manifault.com > Subject: [PATCH] update the consistency issue in documentation > > From fa9f3f47ddeb3e9a615c17aea57d2ecd53a7d201 Mon Sep 17 00:00:00 > 2001 > From: lincyawer <53161583+Lincyaw@users.noreply.github.com> > Date: Thu, 4 Jan 2024 10:51:36 +0800 > Subject: [PATCH] The original documentation of BPF_JMP instructions is > somehow misleading. The code part of instruction, e.g., BPF_JEQ's value is > noted as 0x1, however, in `include/uapi/linux/bpf.h`, the value of BPF_JEQ is > 0x10. At the same time, the description convention is inconsistent with the > BPF_ALU, whose code are also 4bit, but the value of BPF_ADD is 0x00 https://www.ietf.org/archive/id/draft-ietf-bpf-isa-00.html#section-3 says: > ============== ====== ================= > 4 bits (MSB) 1 bit 3 bits (LSB) > ============== ====== ================= > code source instruction class > ============== ====== ================= Hence the code field is 4 bits, and 0x10 cannot fit in a 4 bit field. The documentation is already internally consistent, and this proposed change would make the documentation incorrect. Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ietf.org (mail.ietf.org [50.223.129.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D395D28E06 for ; Thu, 4 Jan 2024 19:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dmarc.ietf.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ietf.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b="w0gFWA9L"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b="ZA+L76NM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="HXsRr9LS" Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CC263C04B956 for ; Thu, 4 Jan 2024 11:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1704395537; bh=Nf1NAzKq38WLgSv96qGj6DkiAgkRmYQ6qIAh4zvVNRM=; h=To:Cc:References:In-Reply-To:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w0gFWA9LNIdY8Yiu2U1x0N+wVON/hTbcfYpkCCBk/PhvpXH5VvH1AbU+NAy8Uq7Mg 3qvW9Y64EN3hDQbclCaLceMv6VF3nO9m+FooU+WKIfMNiaQ1T9EU4e66NxA8U49Q1A MYvg/OIdiG77RoBwPR0I4Wn29Tcfo803OIGFw16s= Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id ABB88C157924; Thu, 4 Jan 2024 11:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1704395537; bh=Nf1NAzKq38WLgSv96qGj6DkiAgkRmYQ6qIAh4zvVNRM=; h=From:To:Cc:References:In-Reply-To:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=ZA+L76NMIdj/2KAWVc+2JE7/djkrMulYmX6mbJnZFvCAK1usA90LmgbriSfoblurP D+hHguRB4vw/AjeBE+a9JSd8JGQuCZUKpqB3mInhw6GwhtGraCW65x3ieTunUR/8HC DdKanhrV9ntIerE9aKLwBX+sZ5QwSzTXaS6E/WTo= Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 89C0BC157924 for ; Thu, 4 Jan 2024 11:12:16 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -6.855 X-Spam-Level: Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VHM0ts5UzZwv for ; Thu, 4 Jan 2024 11:12:12 -0800 (PST) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E890AC14CE53 for ; Thu, 4 Jan 2024 11:12:12 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d427518d52so5664405ad.0 for ; Thu, 04 Jan 2024 11:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1704395532; x=1705000332; darn=ietf.org; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=wiuAbn1hA+wD2zanBuCoA6Xdp/ZRkyF/eu8Vv75E5eo=; b=HXsRr9LSGn1PiriFQP9UwCEQJGTm7iqZBpu9Nf6fe+b0Qvr4MP0Pk9Tlvx5PBp49vn VYLwiCdb3opiXfTeHTlKMGtkOoIL1np/yWi37tvDGdK+Fc+x1j/Qucy/SZRjrjsz8L10 KX9FdzgiIiAvW5Y8Lx7n4ZUaC/rPJhpK08vl3sP7Lplo5X/wqPdhV87+pwcjUggyDm9X ScG8Zv6tey9etxmPQkTukmsihlgGVkBijVRei7ZvfAqk7r0BsHYvufIQ0AUg8/MHXrE4 p7aX4uY56AcI9MXS/vvxaX2hE5yZMHoesEagJK6voZt8QL08xc8TiC7TOOeoAUJWP1FE 4IXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704395532; x=1705000332; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiuAbn1hA+wD2zanBuCoA6Xdp/ZRkyF/eu8Vv75E5eo=; b=oNhHbFmx6uMFRjoF/xD81zSksWtrglWmbqoeWQSz0ltI2CrP9TWibggaYjXTYIm8b6 vnDs0n4hIQs/an997i84oSU4SapZF8VFdTa22I1KtgkFa01yqUnUh4MjtTau+hu6juh3 KkxFx7NMniW65nzi65SVuNmHmSgY0PwjHZ3E8Bz6GlwAFIc1P0P1k33FE7+a8pbXgNY6 dWX4oEF8FhYAZjUaIIYbrEENMx9xYXRKkm2fywvM8XweH1LNTYe7qfht73Hy0ru3FQkT j/nhvJU1BdaLuxIBrFvoSO58jQ/K5NYZ6yE4PifxuTU++0NTimt3oh08xsGsaZGX3Zxi BrxQ== X-Gm-Message-State: AOJu0YwMzL5XdDalQUyJHOWNXgrynks9IeY3OCboV1fHM2+qvQ5Ieti/ 18V779PAMRHS9EUvNIn7YKydKKkBL+w= X-Google-Smtp-Source: AGHT+IF8NBDEzEGYQcF27Qh4/HMfq2Q29GAe84qQeg2jGA8hMXmsXodkyDwrxrzH/bMNHmGnbODQ7A== X-Received: by 2002:a17:903:484:b0:1d4:e575:520a with SMTP id jj4-20020a170903048400b001d4e575520amr165714plb.46.1704395531858; Thu, 04 Jan 2024 11:12:11 -0800 (PST) Received: from ArmidaleLaptop (c-67-170-74-237.hsd1.wa.comcast.net. [67.170.74.237]) by smtp.gmail.com with ESMTPSA id h9-20020a170902f7c900b001d4752f5403sm17021666plw.206.2024.01.04.11.12.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jan 2024 11:12:11 -0800 (PST) X-Google-Original-From: To: "'Aoyang Fang \(SSE, 222010547\)'" , , Cc: References: <3A7D0A57-02EF-4ACB-A599-1029CFCA7E74@link.cuhk.edu.cn> In-Reply-To: <3A7D0A57-02EF-4ACB-A599-1029CFCA7E74@link.cuhk.edu.cn> Date: Thu, 4 Jan 2024 11:12:09 -0800 Message-ID: <015701da3f41$eaab4d10$c001e730$@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQJcMuQj7ImLqPZXOVe7T7DiaRKhU6/GHKMQ Archived-At: Subject: Re: [Bpf] [PATCH] update the consistency issue in documentation X-BeenThere: bpf@ietf.org X-Mailman-Version: 2.1.39 Precedence: list List-Archive: List-Post: List-Help: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: bpf-bounces@ietf.org Sender: "Bpf" X-Original-From: dthaler1968@googlemail.com From: dthaler1968=40googlemail.com@dmarc.ietf.org Message-ID: <20240104191209.m8Oxd16wAN7CNKg2p7VXUc59X-ktEfR5hyZjnqP2EEM@z> > -----Original Message----- > From: Aoyang Fang (SSE, 222010547) > Sent: Wednesday, January 3, 2024 7:13 PM > To: bpf@vger.kernel.org; bpf@ietf.org > Cc: void@manifault.com > Subject: [PATCH] update the consistency issue in documentation > > From fa9f3f47ddeb3e9a615c17aea57d2ecd53a7d201 Mon Sep 17 00:00:00 > 2001 > From: lincyawer <53161583+Lincyaw@users.noreply.github.com> > Date: Thu, 4 Jan 2024 10:51:36 +0800 > Subject: [PATCH] The original documentation of BPF_JMP instructions is > somehow misleading. The code part of instruction, e.g., BPF_JEQ's value is > noted as 0x1, however, in `include/uapi/linux/bpf.h`, the value of BPF_JEQ is > 0x10. At the same time, the description convention is inconsistent with the > BPF_ALU, whose code are also 4bit, but the value of BPF_ADD is 0x00 https://www.ietf.org/archive/id/draft-ietf-bpf-isa-00.html#section-3 says: > ============== ====== ================= > 4 bits (MSB) 1 bit 3 bits (LSB) > ============== ====== ================= > code source instruction class > ============== ====== ================= Hence the code field is 4 bits, and 0x10 cannot fit in a 4 bit field. The documentation is already internally consistent, and this proposed change would make the documentation incorrect. Dave -- Bpf mailing list Bpf@ietf.org https://www.ietf.org/mailman/listinfo/bpf